Skip to content

#3315 Loop fusion of builtins on the same any_space_#3466

Draft
mo-alistairp wants to merge 4 commits into
masterfrom
3315_any_space_loop_fusion
Draft

#3315 Loop fusion of builtins on the same any_space_#3466
mo-alistairp wants to merge 4 commits into
masterfrom
3315_any_space_loop_fusion

Conversation

@mo-alistairp

Copy link
Copy Markdown
Collaborator

When multiple builtins in an algorithm are on the same any_space_ they should iterate over the same number of DoFs. Hence, these are candidates for fusion. This is currently missed in the LFRic loop fusion validation step and can be extended to allow this increased functionality. This change should allow the removal of some PSyKAl-lite code in LFRic.

@mo-alistairp mo-alistairp self-assigned this Jun 23, 2026
@mo-alistairp mo-alistairp added enhancement in progress LFRic Issue relates to the LFRic domain LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic labels Jun 23, 2026
@mo-alistairp mo-alistairp marked this pull request as draft June 23, 2026 15:55
@mo-alistairp

Copy link
Copy Markdown
Collaborator Author

To note, I've changed test_loop_fuse_error to instead check for correct fusion. This does simultaneously cause a reduction in test coverage in cases where there are builtins on any_space_ but these are different spaces (i.e., the TransformationError on lines 188-192). I'll need to add that coverage too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement in progress LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic LFRic Issue relates to the LFRic domain

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant