(Closes #3446) Update to fix issues with codeblocks and routine names when comments exist.#3456
Open
LonelyCat124 wants to merge 2 commits into
Open
(Closes #3446) Update to fix issues with codeblocks and routine names when comments exist.#3456LonelyCat124 wants to merge 2 commits into
LonelyCat124 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 55067 55068 +1
=========================================
+ Hits 55067 55068 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@sergisiso @arporter This is ready for a first look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this with the original file @schreiberx gave me also and it works now.
The change is just to use walk(...) instead of relying on the fparser structure.