(towards #2551) Add DUC positions caching#3075
Closed
sergisiso wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
@arporter @LonelyCat124 I suggest we already merge this change from #2967 as it speed-up all NEMO integration tests significantly. Ready for review |
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3075 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 367 367
Lines 51755 51758 +3
=======================================
+ Hits 51705 51708 +3
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is just a
git checkout origin/2551_omp_barrier_Removal -- src/psyclone/psyir/tools/definition_use_chains.py, from @LonelyCat124 branch that I already reviewed but that branch still have some integration test issues to fix. However his change in this file brings the processing time of some NEMO files significantly down. And will be very convenient to already merge.The most extreme case is:


to:
The time without profiling is 8s.
PS: these flamecharts are now fully-connected because we got rid of the eval in #3045 :)