Skip to content

(towards #2551) Add DUC positions caching#3075

Closed
sergisiso wants to merge 2 commits into
masterfrom
duc_positions_caching
Closed

(towards #2551) Add DUC positions caching#3075
sergisiso wants to merge 2 commits into
masterfrom
duc_positions_caching

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

This is just a git checkout origin/2551_omp_barrier_Removal -- src/psyclone/psyir/tools/definition_use_chains.py, from @LonelyCat124 branch that I already reviewed but that branch still have some integration test issues to fix. However his change in this file brings the processing time of some NEMO files significantly down. And will be very convenient to already merge.

The most extreme case is:
image
to:
image
The time without profiling is 8s.
PS: these flamecharts are now fully-connected because we got rid of the eval in #3045 :)

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter @LonelyCat124 I suggest we already merge this change from #2967 as it speed-up all NEMO integration tests significantly. Ready for review

@sergisiso

sergisiso commented Jul 25, 2025

Copy link
Copy Markdown
Collaborator Author

I added the caching also somewhere else because I saw that it also dominated the backend time, with this the result is:
image

@codecov

codecov Bot commented Jul 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (dc66e55) to head (cbe7421).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3075   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         367      367           
  Lines       51755    51758    +3     
=======================================
+ Hits        51705    51708    +3     
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso closed this Jul 28, 2025
@sergisiso sergisiso deleted the duc_positions_caching branch August 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant