#3058 Update linkcheck parameters#3059
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3059 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 368 368
Lines 51992 51992
=======================================
Hits 51942 51942
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The problem was that the default behaviour of the action is to filter unmodified lines of code. However this is not what we want as we link against generated pages, we could change what gets generated but keep the broken older link unchanged. We want to always check everything. The action is now working properly, and example of a failed action can be seen here: https://github.com/stfc/PSyclone/actions/runs/16321579276/job/46100483733 |
|
I put this Ready for Review from @hiker even though the action still fails due to the broken links in |
|
@arporter @hiker @LonelyCat124 This is ready for review. It enables proper CI linkchecking in files outside the docs: examples, tutorials, READMEs, ... and fixes many currently broken links. |
arporter
left a comment
There was a problem hiding this comment.
Thanks for fixing this Sergi and saving our blushes. Just a couple of minor things to fix and then this can go on.
Since it's all docstrings/documentation, I won't bother with the integration tests.
|
This is ready for another review @arporter |
arporter
left a comment
There was a problem hiding this comment.
Thanks very much Sergi, all good now.
Will proceed to merge.
No description provided.