Skip to content

Duplicated async statements in OpenACC#3055

Merged
arporter merged 5 commits into
masterfrom
martin_openacc_bugfixes
Jul 21, 2025
Merged

Duplicated async statements in OpenACC#3055
arporter merged 5 commits into
masterfrom
martin_openacc_bugfixes

Conversation

@schreiberx

Copy link
Copy Markdown
Collaborator

The async ACC clause results in duplicated async statements, which are fixed with this PR.

!$acc kernels default(present) async(1) async(1)
!$acc end kernels

.!$acc parallel default(present) async(1) async(1)
!$acc end parallel

.!$acc update if_present host(x) async(1) async(1)

.!$acc enter data copyin(x) async(1)

@codecov

codecov Bot commented Jul 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (1b5eb08) to head (260d03f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files         366      366              
  Lines       51678    51668      -10     
==========================================
- Hits        51638    51628      -10     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso

Copy link
Copy Markdown
Collaborator

@schreiberx Good spot, but we can actually go further and completely remove the _build_async_string. Since the async is in a PSyIR Clause it should be the PSyIR backend that produces the right code when visiting the node and not the the begin_string method. The method was probably a leftover of gen_code.

I took the liberty to do the change in this branch, but this means that the review will need to be finished by @arporter or @LonelyCat124

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much Martin and Sergi.
This looks good.
I've set the integration tests running. If they are green then this is good to go.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests were all green.
Will proceed to merge.

@arporter arporter merged commit da26341 into master Jul 21, 2025
12 checks passed
@arporter arporter deleted the martin_openacc_bugfixes branch July 21, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants