(closes #3045) Replace eval with getattr#3046
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3046 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 366 366
Lines 51566 51566
=======================================
Hits 51526 51526
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@arporter @LonelyCat124 @hiker This is ready for review. |
sergisiso
changed the title
LonelyCat124
approved these changes
Jul 18, 2025
LonelyCat124
left a comment
LonelyCat124
left a comment
Collaborator
There was a problem hiding this comment.
Happy to merge this @sergisiso - don't think anything functionally changes here so I'll skip the integration tests for this PR.
sergisiso
pushed a commit
that referenced
this pull request
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's a quick one, I don't know why we (probably me) didn't use getattr to begin with.