(towards #2971) move OMPDeclareTargetTrans and MarkRoutineForGPUMixin#3042
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3042 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 371 373 +2
Lines 52155 52165 +10
=======================================
+ Hits 52105 52115 +10
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arporter @sergisiso @LonelyCat124 this is ready for review, thank you |
LonelyCat124
left a comment
There was a problem hiding this comment.
Hi @victoria-atkinson looks good, I have a few very minor formatting changes to be done, but I'll set off the integration in the mean time and once those are done we can merge.
Can you update your comment in #2668 to include these too.
|
Thanks @LonelyCat124 done and comment updated. |
|
@victoria-atkinson Hi Victoria - a lot of the |
@LonelyCat124 Thanks Aidan, sorry I missed your comment about kernel_transformation_test.py. I've updated the formatting in that file but there was only one that needed changing, am I missing some others somewhere? |
|
@victoria-atkinson Think maybe my github had cached a previous version of some of the files. They all look fine now, I'll probably have a final look at this and (probably) merge it on Friday or next Monady. |
|
@LonelyCat124 great, thanks Aidan! |
LonelyCat124
left a comment
There was a problem hiding this comment.
Everything looks good now, will proceed to merge.
No description provided.