Skip to content

(towards #2971) move OMPDeclareTargetTrans and MarkRoutineForGPUMixin#3042

Merged
LonelyCat124 merged 12 commits into
masterfrom
2971_move_transformations
Aug 5, 2025
Merged

(towards #2971) move OMPDeclareTargetTrans and MarkRoutineForGPUMixin#3042
LonelyCat124 merged 12 commits into
masterfrom
2971_move_transformations

Conversation

@victoria-atkinson

Copy link
Copy Markdown
Collaborator

No description provided.

@victoria-atkinson victoria-atkinson changed the base branch from master to 2971_move_remaining_trans July 1, 2025 13:59
Base automatically changed from 2971_move_remaining_trans to master July 16, 2025 14:17
@victoria-atkinson victoria-atkinson self-assigned this Jul 17, 2025
@codecov

codecov Bot commented Jul 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (db97b9c) to head (980574c).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3042   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         371      373    +2     
  Lines       52155    52165   +10     
=======================================
+ Hits        52105    52115   +10     
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victoria-atkinson victoria-atkinson changed the title (towards #2971) move remaining transformations (towards #2971) move OMPDeclareTargetTrans and MarkRoutineForGPUMixin Jul 17, 2025
@victoria-atkinson

Copy link
Copy Markdown
Collaborator Author

@arporter @sergisiso @LonelyCat124 this is ready for review, thank you

@LonelyCat124 LonelyCat124 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @victoria-atkinson looks good, I have a few very minor formatting changes to be done, but I'll set off the integration in the mean time and once those are done we can merge.

Can you update your comment in #2668 to include these too.

Comment thread src/psyclone/tests/psyir/transformations/kernel_transformation_test.py Outdated
Comment thread src/psyclone/tests/psyir/transformations/transformations_test.py Outdated
@victoria-atkinson

Copy link
Copy Markdown
Collaborator Author

Thanks @LonelyCat124 done and comment updated.

@LonelyCat124

Copy link
Copy Markdown
Collaborator

@victoria-atkinson Hi Victoria - a lot of the \ linebreaks I'd commented about are still there, can you fix those up. Having to rerun integration as one failed due to a known compiler issue.

@victoria-atkinson

Copy link
Copy Markdown
Collaborator Author

@victoria-atkinson Hi Victoria - a lot of the \ linebreaks I'd commented about are still there, can you fix those up. Having to rerun integration as one failed due to a known compiler issue.

@LonelyCat124 Thanks Aidan, sorry I missed your comment about kernel_transformation_test.py. I've updated the formatting in that file but there was only one that needed changing, am I missing some others somewhere?

@LonelyCat124

Copy link
Copy Markdown
Collaborator

@victoria-atkinson Think maybe my github had cached a previous version of some of the files. They all look fine now, I'll probably have a final look at this and (probably) merge it on Friday or next Monady.

@victoria-atkinson

Copy link
Copy Markdown
Collaborator Author

@LonelyCat124 great, thanks Aidan!

@LonelyCat124 LonelyCat124 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now, will proceed to merge.

Comment thread src/psyclone/tests/psyir/transformations/transformations_test.py Outdated
@LonelyCat124 LonelyCat124 merged commit 7607436 into master Aug 5, 2025
11 checks passed
@LonelyCat124 LonelyCat124 deleted the 2971_move_transformations branch August 5, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants