Skip to content

(closes #2823) Parse unresolved symbols with parenthesis as calls#3041

Merged
arporter merged 80 commits into
masterfrom
unresolved_as_calls
Dec 1, 2025
Merged

(closes #2823) Parse unresolved symbols with parenthesis as calls#3041
arporter merged 80 commits into
masterfrom
unresolved_as_calls

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Jun 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (89ed5af) to head (b6409db).
⚠️ Report is 81 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3041   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         375      375           
  Lines       53286    53345   +59     
=======================================
+ Hits        53231    53290   +59     
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/psyclone/tests/psyir/backend/sympy_writer_test.py Outdated
@sergisiso sergisiso self-assigned this Jul 16, 2025
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter Now that we have released, this is ready for another look. Since now we do indirect imports, I could finally remove the whole enhance_tree_information

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergi, it's great to see the simplifications to the NEMO scripts.
I was all set to say "just minor things" but then realised that character substrings are still likely to be a problem - see inline. This is partly because fparser always seems to create a Subscript_Triplet whenever it sees a colon.

Comment thread examples/nemo/scripts/omp_gpu_trans.py Outdated
Comment thread src/psyclone/psyclonefc_cli.py
Comment thread src/psyclone/psyir/frontend/fparser2.py Outdated
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py
Comment thread src/psyclone/psyir/transformations/parallel_loop_trans.py Outdated
Comment thread src/psyclone/tests/psyir/frontend/fparser2_part_ref_test.py
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter Your coment got me worried that we were infering the wrong type for character substrings but we do not, they end up as UnresolvedType. The node type has not been changed by this PR, so I suggest we discuss character substring in a separate issue. This is ready for review.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for digging into the character-string issue and apologies for worrying you unnecessarily :-)
I've brought the branch to master and am double checking the IT. Once they come back I'll proceed to merge.

@arporter

arporter commented Dec 1, 2025

Copy link
Copy Markdown
Member

Integration tests were all green. Will proceed to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants