(closes #2823) Parse unresolved symbols with parenthesis as calls#3041
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3041 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 375 375
Lines 53286 53345 +59
=======================================
+ Hits 53231 53290 +59
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…with_usage_location method
…ormance for NEMOv4
…s (and not offloading much)
f19ab6b to
d4d6b73
Compare
d4d6b73 to
706249e
Compare
|
@arporter Now that we have released, this is ready for another look. Since now we do indirect imports, I could finally remove the whole |
There was a problem hiding this comment.
Thanks Sergi, it's great to see the simplifications to the NEMO scripts.
I was all set to say "just minor things" but then realised that character substrings are still likely to be a problem - see inline. This is partly because fparser always seems to create a Subscript_Triplet whenever it sees a colon.
|
@arporter Your coment got me worried that we were infering the wrong type for character substrings but we do not, they end up as UnresolvedType. The node type has not been changed by this PR, so I suggest we discuss character substring in a separate issue. This is ready for review. |
arporter
left a comment
There was a problem hiding this comment.
All good now, thanks for digging into the character-string issue and apologies for worrying you unnecessarily :-)
I've brought the branch to master and am double checking the IT. Once they come back I'll proceed to merge.
|
Integration tests were all green. Will proceed to merge. |
No description provided.