(closes #3036) Remove AccessType location and is_accessed_before method

[sergisiso]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (887526d) to head (435ca4c).
⚠️ Report is 3392 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files         366      366              
  Lines       51721    51566     -155     
==========================================
- Hits        51681    51526     -155     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sergisiso]

@arporter @LonelyCat124 @hiker This is ready for review, it removes some functionality from AccessType that has some important limitations and has been superseded by the DefUseChains anyway.

[arporter]

Thanks Sergi, this is a big chunk of code removed! I only have very minor comments.
I've fired off the integration tests.
I've grepped through the examples, docs and code and can't find any mentions of 'location' that need updating.

[sergisiso]

@arporter This is ready for another review

[arporter]

All requested changes have been made and all integration tests were green (with only type-hint changes since then).
Will proceed to merge.