(closes #3012) Initial version of psyclonefc command#3023
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3023 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 368 370 +2
Lines 51992 52054 +62
=======================================
+ Hits 51942 52004 +62
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arporter I have scaled this PR back, make it just a towards, and mark it ready for review. The reason is that I don't think we should advertise/document it until we figure out what to do with the intercepted -J/-I and we apply the preprocessor step (these are its main value proposition). However, it can already provide value to Imaran/Chris and other internal NEMO workflows, but since these are also happening in branches it makes it hard to combine them. So, it would be convenient to introduce this barebones psyclonefc to master for internal use and finish it later. |
arporter
left a comment
There was a problem hiding this comment.
Looks good Sergi, thanks very much. I agree with the not publicising it yet but please add a checklist item to the original issue that we need to write a section on this functionality in the user guide.
Would it be possible to extend one or more of the examples to use this functionality so that it gets exercised "for real"?
Apart from that, it's just some minor things. Thanks very much for removing the logging TODO in the SymbolTable!
|
@arporter This is ready for review. I pushed back on some of the comments as at this stage I am unsure how it should work but
I agree with this, and I listed all the missing aspects
I converted two steps of the integration test into using psyclonefc (should I convert also the other actions?) |
arporter
left a comment
There was a problem hiding this comment.
Thanks Sergi. All good now. Will proceed to merge.
No description provided.