Skip to content

(closes #3012) Initial version of psyclonefc command#3023

Merged
arporter merged 29 commits into
masterfrom
psyclonefc_command
Jul 29, 2025
Merged

(closes #3012) Initial version of psyclonefc command#3023
arporter merged 29 commits into
masterfrom
psyclonefc_command

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread .github/workflows/nemo_v5_tests.yml Outdated
Comment thread .github/workflows/nemo_v5_tests.yml
@codecov

codecov Bot commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (a320ebd) to head (a72aeb2).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3023   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         368      370    +2     
  Lines       51992    52054   +62     
=======================================
+ Hits        51942    52004   +62     
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso requested a review from arporter July 24, 2025 20:05
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter I have scaled this PR back, make it just a towards, and mark it ready for review. The reason is that I don't think we should advertise/document it until we figure out what to do with the intercepted -J/-I and we apply the preprocessor step (these are its main value proposition). However, it can already provide value to Imaran/Chris and other internal NEMO workflows, but since these are also happening in branches it makes it hard to combine them. So, it would be convenient to introduce this barebones psyclonefc to master for internal use and finish it later.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Sergi, thanks very much. I agree with the not publicising it yet but please add a checklist item to the original issue that we need to write a section on this functionality in the user guide.
Would it be possible to extend one or more of the examples to use this functionality so that it gets exercised "for real"?
Apart from that, it's just some minor things. Thanks very much for removing the logging TODO in the SymbolTable!

Comment thread bin/psyclonefc Outdated
Comment thread examples/nemo/scripts/utils.py
Comment thread src/psyclone/psyclonefc_cli.py Outdated
Comment thread src/psyclone/psyclonefc_cli.py Outdated
Comment thread src/psyclone/psyclonefc_cli.py
Comment thread src/psyclone/tests/psyclonefc_cli_test.py Outdated
Comment thread src/psyclone/tests/psyclonefc_cli_test.py
Comment thread src/psyclone/tests/psyclonefc_cli_test.py Outdated
Comment thread src/psyclone/tests/psyir/symbols/symbol_table_test.py Outdated
Comment thread src/psyclone/tests/psyir/symbols/symbol_table_test.py
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter This is ready for review. I pushed back on some of the comments as at this stage I am unsure how it should work but

add a checklist item to the original issue that we need to write a section on this functionality in the user guide.

I agree with this, and I listed all the missing aspects

Would it be possible to extend one or more of the examples to use this functionality so that it gets exercised "for real"?

I converted two steps of the integration test into using psyclonefc (should I convert also the other actions?)

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergi. All good now. Will proceed to merge.

@arporter arporter merged commit c34b8b8 into master Jul 29, 2025
11 checks passed
@arporter arporter deleted the psyclonefc_command branch July 29, 2025 09:31
arporter added a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants