2923 support boolean in sympy#2997
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2997 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 365 365
Lines 51671 51716 +45
=======================================
+ Hits 51630 51675 +45
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I did run the CI, then noticed that it was outdated and updated it. But it is ready for a first look: nemo5 failed, but that seems to be failing everywhere(?) |
sergisiso
left a comment
There was a problem hiding this comment.
The PR looks good @hiker, I have some minor questions about typing, mypy and sympy printing. The integration test should be passing but zdfsh2.f90 has given issues before, you could exclude this file in OFFLOADING_ISSUES if it is just this.
sergisiso
left a comment
There was a problem hiding this comment.
All comments are resolved and the integration test was green, this is ready to merge.
Adds support for logical operators in the Sympy interface (i.e. reading and writing)