Skip to content

2923 support boolean in sympy#2997

Merged
sergisiso merged 14 commits into
masterfrom
2923_support_boolean_in_sympy
Jul 7, 2025
Merged

2923 support boolean in sympy#2997
sergisiso merged 14 commits into
masterfrom
2923_support_boolean_in_sympy

Conversation

@hiker

@hiker hiker commented May 16, 2025

Copy link
Copy Markdown
Collaborator

Adds support for logical operators in the Sympy interface (i.e. reading and writing)

@hiker hiker mentioned this pull request May 16, 2025
@codecov

codecov Bot commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (68109b3) to head (5f180f6).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2997   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         365      365           
  Lines       51671    51716   +45     
=======================================
+ Hits        51630    51675   +45     
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker hiker temporarily deployed to integration May 18, 2025 15:34 — with GitHub Actions Inactive
@hiker hiker temporarily deployed to integration July 1, 2025 01:37 — with GitHub Actions Inactive
@hiker

hiker commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator Author

I did run the CI, then noticed that it was outdated and updated it. But it is ready for a first look: nemo5 failed, but that seems to be failing everywhere(?)

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good @hiker, I have some minor questions about typing, mypy and sympy printing. The integration test should be passing but zdfsh2.f90 has given issues before, you could exclude this file in OFFLOADING_ISSUES if it is just this.

Comment thread src/psyclone/psyir/backend/sympy_writer.py Outdated
Comment thread src/psyclone/psyir/backend/sympy_writer.py Outdated
Comment thread src/psyclone/psyir/backend/sympy_writer.py Outdated
Comment thread src/psyclone/psyir/frontend/sympy_reader.py Outdated
Comment thread src/psyclone/psyir/frontend/sympy_reader.py

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are resolved and the integration test was green, this is ready to merge.

@sergisiso sergisiso merged commit 80b372f into master Jul 7, 2025
11 checks passed
@sergisiso sergisiso deleted the 2923_support_boolean_in_sympy branch July 7, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants