2878 extraction update#2907
Conversation
…ort the new names of the various lfric fields.
…more fields. Improved output format.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2907 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 368 368
Lines 51992 51992
=======================================
Hits 51942 51942
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This makes the extraction comparison more readable (using ints instead of floating point format), fixes a but or two, and also includes the a compiled and executed test of the comparison library. |
|
Looks like I forgot to mark this as ready. I've brought it up to latest master, and triggered the CI (which should not really be affected by the changes here). |
|
@hiker Unfortunately the libraries compilation failed with: |
|
Which compiler (and version) is that? I've tried nvfortran (23.5), gfortran (11.4), ifort (2021.8.0), and ifx(2023.0.0), and they are all working fine. Ah, found it - gfortran 15. As far as I can see, I don't have access to that atm :( I'll see if I can figure out what is happening. |
|
I think I got it. I'll trigger the full CI tomorrow. |
|
I've fixed the conflict in the changelog, I don't think there's a need to rerun the CI because of this. |
|
Thanks @hiker, this ca be merged now |
Fixed #2878 (and other minor improvements to output format to make it easier to read).