Skip to content

(Closes #2716) Add support for module-inlining calls to polymorphic kernels/routines#2732

Merged
sergisiso merged 130 commits into
masterfrom
2716_transform_interface_bug
Jun 30, 2025
Merged

(Closes #2716) Add support for module-inlining calls to polymorphic kernels/routines#2732
sergisiso merged 130 commits into
masterfrom
2716_transform_interface_bug

Conversation

@arporter

@arporter arporter commented Oct 3, 2024

Copy link
Copy Markdown
Member

No description provided.

@arporter arporter self-assigned this Oct 3, 2024
@arporter arporter marked this pull request as draft October 3, 2024 09:12
@arporter arporter added in progress NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH labels Oct 3, 2024
@codecov

codecov Bot commented Oct 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (e8f0021) to head (00c36fd).
Report is 131 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2732   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         364      364           
  Lines       51697    51781   +84     
=======================================
+ Hits        51652    51739   +87     
+ Misses         45       42    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter

arporter commented Oct 3, 2024

Copy link
Copy Markdown
Member Author

As well as addressing the coverage, I need to extend the LFRic integration tests to use this new functionality.

@arporter

arporter commented Oct 7, 2024

Copy link
Copy Markdown
Member Author

Added the KernelModuleInlineTrans back into the LFRic transformation script and get a crash when trying to add the interface symbol into the symbol table.

@arporter

Copy link
Copy Markdown
Member Author

Ready for another look now. CodeCov is doing weird things but perhaps it will get sorted out if master moves on and then we bring this branch up to date.

@sergisiso

sergisiso commented Jun 30, 2025

Copy link
Copy Markdown
Collaborator

@arporter since you are on AL I fixed the merge conflicts and removed a leftover get_kernel_schedule myself as I want to proceed with the integration tests for this PR.

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter All my previous comments have been addressed, the coverage was complete and the integration tests all passed (the system was noisy but there seems to be a slowdown by doing more kernels on the gpu, this is acceptable as the coverage is significantly increased and we don't do the code-inline and atomics yet).

Good job @arporter this has been a long PR but I like how it has end up. This opens the door to do the code-inlining of the mixed kernels and the deprecation of okern.

@sergisiso sergisiso merged commit 86794cd into master Jun 30, 2025
11 checks passed
@sergisiso sergisiso deleted the 2716_transform_interface_bug branch June 30, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants