(Closes #2716) Add support for module-inlining calls to polymorphic kernels/routines#2732
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2732 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 364 364
Lines 51697 51781 +84
=======================================
+ Hits 51652 51739 +87
+ Misses 45 42 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As well as addressing the coverage, I need to extend the LFRic integration tests to use this new functionality. |
|
Added the KernelModuleInlineTrans back into the LFRic transformation script and get a crash when trying to add the interface symbol into the symbol table. |
|
Ready for another look now. CodeCov is doing weird things but perhaps it will get sorted out if master moves on and then we bring this branch up to date. |
|
@arporter since you are on AL I fixed the merge conflicts and removed a leftover get_kernel_schedule myself as I want to proceed with the integration tests for this PR. |
sergisiso
left a comment
There was a problem hiding this comment.
@arporter All my previous comments have been addressed, the coverage was complete and the integration tests all passed (the system was noisy but there seems to be a slowdown by doing more kernels on the gpu, this is acceptable as the coverage is significantly increased and we don't do the code-inline and atomics yet).
Good job @arporter this has been a long PR but I like how it has end up. This opens the door to do the code-inlining of the mixed kernels and the deprecation of okern.
No description provided.