#1312: metadata for read-only arrays

[mo-lottieturner]

.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b393e04) 0.00% compared to head (fe4baf9) 99.84%.

Files	Patch %	Lines
...psyclone/domain/lfric/kernel/array_arg_metadata.py	94.00%	3 Missing ⚠️
...ne/domain/lfric/kernel/common_meta_arg_metadata.py	92.30%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2173       +/-   ##
===========================================
+ Coverage        0   99.84%   +99.84%     
===========================================
  Files           0      353      +353     
  Lines           0    47511    +47511     
===========================================
+ Hits            0    47438    +47438     
- Misses          0       73       +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mo-lottieturner]

(all tests pass except codecov)

[mo-alistairp]

I've added some documentation for the subroutine call. The design in #1312 seems to suggest that the ScalarArray is only variable needed in the subroutine definition, so hopefully this is sufficient. Let me know if you want anything else included in the documentation. Otherwise, I think this is ready for review again.

[arporter]

Thanks Alistair, very nearly there now.
The documentation on the subroutine rules need updating to match what #1312 says.
I think it would also be better to switch to storing the number of dimensions of a ScalarArray as an int.

[arporter]

Thanks for making those changes Alistair. All good now.
I'll proceed to merge.