chore(deps): update dependency nunit to v5 - #114
renovate[bot] wants to merge 1 commit into
Conversation
|
✅ Reviewed 🤖 @argus-pr — automated AI assistant; replies may be wrong. |
There was a problem hiding this comment.
@argus-pr review — 4a6cea4 · model deepseek-v4-flash-vision-exp
Summary — This PR bumps the NUnit test framework package from 4.6.1 to 5.0.0 in src/SqlInliner.Tests/SqlInliner.Tests.csproj. The test suite is compatible with the major-version bump: it targets net8.0 (satisfying NUnit 5's minimum framework), uses Shouldly for all assertions rather than NUnit's removed classic Assert API, and relies only on standard NUnit attributes ([Test], [SetUp], [TearDown], [Platform]) plus TestContext.Out, all of which persist in NUnit 5. The NUnit3TestAdapter remains at 6.2.0, but no incompatibility could be confirmed from the repository, so nothing is flagged.
Risk surface — facts about this change, not findings. A reviewer should start here:
- Dependency changes: dependency manifest(s) changed — verify added/updated dependencies — src/SqlInliner.Tests/SqlInliner.Tests.csproj.
No issues found at or above the MEDIUM threshold. ✅
That is this review finding nothing on the risk surface above — not a finding that there is nothing there.
| Severity | Posted | Suppressed |
|---|---|---|
| CRITICAL | 0 | 0 |
| HIGH | 0 | 0 |
| MEDIUM | 0 | 0 |
| LOW | 0 | 0 |
What this review did — 1 of 1 pass(es) over 1 file(s)
- Passes completed: 1 of 1
- Files reviewed: 1 of 1
- Tool calls made while investigating: 25
What it chose to check — the panel's own reading of what mattered here, planned before it looked. Feedback for a reviewer, not a guarantee that each check was completed:
- Read the test project file at head and base to see target frameworks and all test-related package versions (NUnit, NUnit3TestAdapter, Microsoft.NET.Test.Sdk) (via get_pr_diff on src/SqlInliner.Tests/SqlInliner.Tests.csproj plus read_file at head and read_file_at_base)
- Grep the test project for NUnit APIs that NUnit 5.0.0 may have removed or changed (classic asserts like Assert.AreEqual/Assert.IsTrue, Assert.That, TestCase, SetUp, OneTimeSetUp, TestContext) (via grep for 'Assert.' and '[Test' / '[TestCase' / '[SetUp' in src/SqlInliner.Tests)
- Confirm the test project's target framework(s) satisfy NUnit 5.0.0's minimum framework requirement (via read_file on src/SqlInliner.Tests/SqlInliner.Tests.csproj)
- Check whether the NUnit3TestAdapter version in the csproj is compatible with NUnit 5.0.0 (via read_file on src/SqlInliner.Tests/SqlInliner.Tests.csproj)
- Verify the project builds/tests are not otherwise affected by the version bump (e.g. any NUnit-specific config or analyzer packages) (via grep for 'NUnit' in src/SqlInliner.Tests and read the csproj)
🤖 Reviewed by @argus-pr (AI, model deepseek-v4-flash-vision-exp) — automated, may be wrong. Reply @argus-pr help for commands.
This PR contains the following updates:
4.6.1→5.0.0Release Notes
nunit/nunit (NUnit)
v5.0.0: Version 5.0.0See release notes for details.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.