Repository navigation
Compare resolved paths in legacy-profile and windows-updates tests - #23
Merged
Merged
Conversation
On Darwin, /tmp and /var resolve under /private, so migrate_profile and pending return resolved Paths. Match the test expects. Split from stevecad#18.
Contributor
|
Thanks! We have a few things from you to look at already, and we'll get to this one soon. We look at a few items from each person a day, so everyone gets a turn. |
1 similar comment
Contributor
|
Thanks! We have a few things from you to look at already, and we'll get to this one soon. We look at a few items from each person a day, so everyone gets a turn. |
Contributor
|
Thanks for the contribution! These test edits only address failures on macOS, which Steve desktop doesn't currently support, so a maintainer needs to decide whether to take them as platform work. We'll follow up here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What doesn't work
On macOS,
/tmpand/varare symlinks to/private/tmpand/private/var. Temp paths fromtempfiletherefore show up as/var/folders/…, while anything that callsPath.resolve()returns/private/var/folders/….Two unit tests fail only on Mac because they assert an unresolved temp path against a resolved return value:
target == root/'Steve/CAD'butmigrate_profilereturns a resolved path (/private/var/folders/…).pending(profile) == candidatebutpendingreturns a resolved candidate.The change
tests/test_legacy_profile.py: expect(root/'Steve/CAD').resolve().tests/test_windows_updates.py: expectcandidate.resolve().No production code change. No change to report redaction (that lands in the companion PR). No change to
windows_updates.py, updater, signing,local_git.py, workflows, or deps. Split from #18; this PR carries only the two test expects.Tests
Studio Mac (
/tmp/cadmac-smoke/venvread-only,PYTHONPATH=src:.,QT_QPA_PLATFORM=offscreen, vault_hook armed underpython -m unittest,pgrep SecurityAgentempty before and after; no smoke test;/tmp/cadmac-smokeleft alone):unittest discover583e85805e0b855The remaining 2 discover failures on this branch are: the redaction test (covered by the companion PR) plus a pre-existing
test_hot_workerfailure also present on upstream main on this Studio (not introduced here). Focused legacy + windows modules are green standalone.