Repository navigation
Fence stale network results and bind images to build recipes - #2
Merged
Merged
Conversation
10-X-eng
marked this pull request as ready for review
October 22, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A caller-owned directory search could sample time before waiting for the shop database write lock, then settle successfully after its deadline with an already-expired supplier candidate.
NetworkServicenow samples time inside the transaction for submission and completion. A regression exercises deadline and candidate-expiry crossings. An independent no-network fixture using an actual SQLite writer lock reproduced the old success and verified rejection with this change.Worker and runtime launchers now verify the exact Dockerfile recipe hash in each selected image as well as the SDK and dependency fingerprints. Builders stamp that hash into the images, so an image built before a recipe-only security change cannot be selected silently. The public repository also ignores common private-key exports. Federation restore guidance now requires owner/credential reconciliation and lease expiry before reopening a restored cloud listener.
The live OpenBao workload test now waits for the restored node to report active health after unseal before testing its AppRole, matching the existing recovery test's readiness rule. This addresses an intermittent HTTP 500 seen immediately after restore in CI. The service-pool test also treats a process that disappears between
/proclookup and read as terminated; the focused case passed in the restricted local sandbox.Validation: 15 focused runtime/network tests passed in a bounded no-network Docker sandbox. The deep whole-repository security review covered 97 units and independently verified one low-severity network receipt-integrity finding, fixed here. All seven required PR CI checks passed on commit
3b86f32(run 39858757505).Existing selected images must be rebuilt from this checkout before the updated launchers will accept them. Public deployment still requires site-specific identity, network, secret-custody and restore qualification.