Repository navigation
Tile large adaptive steering grids without changing cutting resolution - #372
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193.
A 2 mm end mill clearing a 400 × 400 mm blank at 0.25 mm radial engagement needs an 8,168 × 8,168 steering grid. Both AdaptivePocket and adaptive Roughing refuse that job on the base commit before the first cut.
Large layers now store cleared heights by tile, read neighbouring material across tile boundaries and track the best enclosed entry per tile. The candidate order, 0.05 mm fine lattice, stroke proofs and stock-generation checks are shared with the existing planner. The planning-memory check still applies after bounding the operation. Cancellation during entry classification requires the classification to finish on retry.
The end-to-end regressions machine a connected rim around a square boss from solid stock through both public operations. They check decoded posted motion, stock contact, removal on all four sides, the floor, the retained boss and the proven engagement angle. The tile regression compares candidates with whole-grid Euclidean distance transforms, including after a cut and rollback.
Linux release, 400 × 400 mm solid stock, 2 mm cutter and 0.25 mm radial engagement. The declared angular limit is 41.409622°. Both checked posts passed with zero stock-contact violations or uncertain motions. The independent stock checks cover the floor, all four cut sides and the retained boss.
All 64 workloads completed on both commits with identical recorded toolpaths, material, cycle times and engagement results. Release runs used the same Linux host and three repeats per workload. To isolate the engine from Python and CAD startup, the four adaptive benchmark manifests were also replayed against the two release binaries in alternating order, pinned to the same CPU. The native columns are medians after warm-up.
The short pocket's full-run slowdown did not repeat in either pinned comparison. Individual timings varied with host load. The four adaptive workloads together took 32.80 → 29.29 seconds in the full benchmark. All four executed fewer native instructions and used less native peak memory in the direct comparisons.
Linux workspace tests passed (458 unit, 666 integration, one doctest, five ignored). The 30 mm dense controls and 400 mm tiled jobs passed through the release build. Linux and Windows CI passed, including the installed Windows wheel, LinuxCNC interpreter, minimum Rust version and benchmark expectations.