Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
12e3b7d
Run the independent leading-contact check on the adaptive pocket test…
Wookie1 Nov 18, 2026
afb22e6
Remove the disk_front and stock_front adaptive planners (#190)
Wookie1 Nov 18, 2026
7178286
Read saved engagement_front programs without the removed orbit fields…
Wookie1 Nov 19, 2026
599021d
Size the leading-contact check's sliver allowance by actual sample sp…
Wookie1 Nov 19, 2026
fb82773
Merge remote-tracking branch 'upstream/main' into pocket-leading-oracle
Wookie1 Nov 19, 2026
7271957
Merge branch 'pocket-leading-oracle' into remove-disk-front
Wookie1 Nov 19, 2026
f78ebc1
Name the leading-contact disc type (clippy type_complexity)
Wookie1 Nov 19, 2026
e1bc8d5
Merge branch 'pocket-leading-oracle' into remove-disk-front
Wookie1 Nov 19, 2026
fe0c5d9
Measure the leading contact against the exact swept path (#190)
Wookie1 Nov 20, 2026
dafaa00
Merge branch 'pocket-leading-oracle' into remove-disk-front
Wookie1 Nov 20, 2026
b6a2610
Merge branch 'pocket-leading-oracle' into remove-disk-front
Wookie1 Nov 20, 2026
e50d352
Declare the oracle's grid cell width
Wookie1 Nov 20, 2026
f227e31
Reject duplicate fields in saved roughing clearing (#190)
Wookie1 Nov 20, 2026
8c7cd01
Merge remote-tracking branch 'upstream/main' into remove-disk-front
Wookie1 Nov 20, 2026
cd68ed8
Restore the L-pocket sweep helper the corner-cap test uses (#190)
Wookie1 Nov 20, 2026
e84c112
Measure pocket engagement against stock cleared at each depth
10-X-eng Nov 21, 2026
b1475ea
Merge commit 'e84c11277cce3fd0c05df53555e46662c17285d1' into HEAD
10-X-eng Nov 21, 2026
591fca2
AdaptivePocket tests: run the independent leading-contact check (#190…
Wookie1 Nov 21, 2026
2bc2919
Resolve the adaptive test overlap with the queued leading-contact checks
10-X-eng Nov 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 24 additions & 43 deletions docs/operations.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ machine, so they have no defaults: pass them as keyword arguments.
| `work_offset` | 1 | 1..9 → G54..G59.x |
| `retract_z_mm` | `clearance_z_mm` | Rapid travel height between passes (Pocket, RestPocket, AdaptivePocket, Roughing, Contour, Chamfer, Facing, TrochoidalSlot, Bore, Parallel, Spiral, Radial, Project, Waterline, Trace) |
| `feed_z_mm` | `retract_z_mm` | Rapid descent stops here and plunge feed begins; leaving a pass, feed changes to rapid here |
| `boundary_tolerance_mm` | 0.01 | Allowed construction error of offset boundaries (Contour, Chamfer, Bore, TrochoidalSlot, adaptive clearing) |
| `boundary_tolerance_mm` | 0.01 | Allowed construction error of offset boundaries (Contour, Chamfer, Bore, TrochoidalSlot) |
| `reverse` | off | Run the passes the other way: Facing and Parallel start each pass from the opposite end, Waterline cuts its contours the other way, Contour/Chamfer (`None` = from `cutting_sense`) reverse the loop direction |
| `one_way` | off | Parallel: cut every row in the same direction instead of alternating (see [Parallel finishing](#parallel-finishing-parallel)); Facing has `mode="one_way"` |

Expand Down Expand Up @@ -169,17 +169,16 @@ without a word:
`AdaptivePocket` no place in that connected area of tool centres is clear
of material to enter from and no helix the entry allows fits (a helix the
policy forbids, `StockEdgeEntry(helix=None)`, is no way in), or the area is
tighter than the planner resolves (below); for `disk_front` and
`stock_front` no orbit fits. The message names the operation, a tool-centre
position in the area, the area's extent, what was tried (the helix or orbit
tighter than the planner resolves (below). The message names the operation, a tool-centre
position in the area, the area's extent, what was tried (the helix
radii and what the area leaves) and the options: another entry
(`RampEntry`, a plunge, a smaller helix), a smaller cutter, an earlier
operation that opens a start there, or a region without that area.
- **A region the cutter fits nowhere in refuses the operation**, since it
can do nothing it was asked to. (This used to be an empty plan with a
`CamWarning`.)
- `Pocket`, `RestPocket`, `disk_front` and `stock_front` refuse before any
motion. `AdaptivePocket`'s default strategy plans from the stock, so it
- `Pocket` and `RestPocket` refuse before any
motion. `AdaptivePocket` plans from the stock, so it
refuses when a level starts, before that level's first motion: for the
first level that is before any motion of the operation.
- **Not refused:** a pocket with nothing left to cut, and the parts of a
Expand Down Expand Up @@ -374,8 +373,6 @@ Decisions (#219), with the reason:
place, and it would ramp through the air beside the stock and through the
air the layers above have cut (a layer's pocket starts at the stock top
while the flutes span it). Use `AdaptiveClearing` for a ramp.
- **`path_strategy="disk_front"` and `"stock_front"` refuse it**: they start
every pass from a fitted seed circle, which a helix opens.
- **A `Contour` ramp with holding tabs stays refused.** A tab is a lift whose
far side comes back down into the uncut loop at the tab's own slope (45
degrees for a triangle, straight down for a rectangle). A tool that needs a
Expand All @@ -397,8 +394,8 @@ Refused, before any motion:
- `RampEntry` on a `Contour` with holding tabs, or with limits that block part
of a loop: the tool comes back down from a tab or a lift steeper than the
ramp angle. A `Contour` accepts no other entry type.
- `RampEntry` on `Roughing` with offset or raster clearing, and with the
`disk_front` and `stock_front` strategies (see the decisions above).
- `RampEntry` on `Roughing` with offset or raster clearing (see the
decisions above).

Refused while running (the run stops and no program is written):

Expand All @@ -418,7 +415,15 @@ Same region and depths as `Pocket`, cleared with a bounded radial engagement:
no full-width slotting, for hard materials and high-speed toolpaths.
`retract_z_mm`/`feed_z_mm` work as for `Pocket`.

- **It follows the stock** (`path_strategy="engagement_front"`, the default):
- **It follows the stock** (`path_strategy="engagement_front"`, the only
planner; the orbit planners `disk_front` and `stock_front` were removed in
#190 and their names are refused. A program saved earlier that chose
`engagement_front` still reads: the orbit fields the earlier serializers
wrote with it (`orbit_radius_mm` and its siblings as null,
`boundary_tolerance_mm`, and an adaptive pocket's `clockwise`) are dropped,
since the engagement front never used them. One saved without a
`path_strategy` was planned by the old default, `disk_front`, and is refused
with that reason):
one depth level at a time, each pass runs along the boundary between cut
and uncut stock inside the region, so nothing is cut twice. The region's
boundary is a wall.
Expand Down Expand Up @@ -525,27 +530,10 @@ no full-width slotting, for hard materials and high-speed toolpaths.
- `ramp_clearance_mm`: each helix starts this far above the material it
meets, never above `feed_z_mm`.
The wall pass is reached like any other pass (a stay-down link, or a
descent with these options) and enters on its lead-in arc at `feed_mm_min`. `path_strategy="disk_front"` and `"stock_front"`
refuse all four by name.
- Orbit options, `max_stay_down_mm` and `rest_tolerance_mm` do not apply and
are refused. Corners the cutter cannot reach are left and reported as the
level's residual area.
- `path_strategy="disk_front"` is the earlier planner: it covers the region
with orbits of `orbit_radius_mm` (default half the tool radius) whatever
the stock holds. Its orbits overlap, so it cuts many times longer (33.7 m
against 1.1 m on a 50 x 30 x 8 mm pocket with a 10 mm cutter). With it,
`clockwise` sets the orbit direction, `max_engagement_deg` (default 90)
bounds the total contact, and `min_orbit_radius_mm` with
`local_orbit_tolerance_mm` sizes each orbit from the clearance around it.
An orbit sweeps a disk of the cutter radius plus the orbit radius. An
area of the region the cutter fits in (a component of its tool-centre
region) that is nowhere that wide is an area no entry reaches: the pocket
is refused before any motion with the sweep's size and the options (#250;
it used to be left). The narrower parts of an area an orbit does fit in
are left and reported in the plan's residual region, as before. The same
holds for `stock_front`.
- `path_strategy="stock_front"` is a development strategy; it stops with an
error where its coverage is unresolved.
descent with these options) and enters on its lead-in arc at `feed_mm_min`.
- `max_stay_down_mm` and `rest_tolerance_mm` do not apply and are refused.
Corners the cutter cannot reach are left and reported as the level's
residual area.

## Surface mesh inputs

Expand Down Expand Up @@ -608,7 +596,7 @@ refused with its location: export the mesh with shared edge vertices
passes, with that much overlap reserved for the coverage proof,
- `AdaptiveClearing(max_radial_engagement_mm)`: engagement-limited clearing
that follows the boundary between cut and uncut stock
(`path_strategy="engagement_front"`, the default). Passes start from air
(`path_strategy="engagement_front"`, the only planner, #190). Passes start from air
beside the stock or from stock already cleared (proven clear by the
committed cuts) and helix only into enclosed material; each pass starts at
the upstream end of the material it cuts; short moves between passes stay
Expand Down Expand Up @@ -670,7 +658,7 @@ refused with its location: export the mesh with shared edge vertices
`wall_passes_skipped`.
- Every cutting and link move is also checked exactly against the layer
region before it is emitted, and the run fails rather than emit one that
does not fit. Orbit options and `omit_empty_cuts` do not apply, the entry
does not fit. `omit_empty_cuts` does not apply, the entry
must be `StockEdgeEntry` or `RampEntry`, and the direction is
`cutting_sense` (`"climb"` by default, `"conventional"`); `clockwise` does
not apply.
Expand All @@ -686,8 +674,8 @@ refused with its location: export the mesh with shared edge vertices
material and no way in (as defined for
[`AdaptivePocket`](#adaptive-pocket-adaptivepocket)) is put in the
layer's report, `layers[].clearing.unentered_areas`: `reason`
(`no_helix_fits`, `no_helix_allowed`, `tighter_than_planner_resolves`,
or `no_orbit_fits` with `stock_front`), `at_mm`, the extent of its tool
(`no_helix_fits`, `no_helix_allowed` or
`tighter_than_planner_resolves`), `at_mm`, the extent of its tool
centres (`min_mm`, `max_mm`), `level_z_mm`, `cutter_radius_mm`,
`radii_tried_mm`, `needed_mm` and `available_mm`. Its stock is in the
layer's residual area, which counts all the stock left in the layer's
Expand All @@ -710,13 +698,6 @@ refused with its location: export the mesh with shared edge vertices
an area has none (for example with `StockEdgeEntry(helix=None)` and an
enclosed area), naming the area, what was tried and the options. They
leave no area without an entry, so they list none.
- `path_strategy="disk_front"` is refused in `Roughing`. It covers a region
it takes to be solid with small orbits and never reads the stock;
`Roughing`'s region is the stock grown by a margin, so it orbited through
the air beside the stock (#167: 75 m of a 137 m path on a 130 x 90 mm
stock). It remains `AdaptivePocket`'s strategy, where the region's
boundary is a wall. `path_strategy="stock_front"` is a development
strategy with the same options as `AdaptivePocket`.
With `rapid_descent_clearance_mm`
(opt-in, on `Roughing`), a descent into a column that the committed cuts
prove clear for the whole tool assembly is rapid down to that far above
Expand Down
5 changes: 1 addition & 4 deletions fixtures/operations/adaptive-connected.json
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,7 @@
"length_register": 1,
"coolant": "flood",
"kind": "adaptive_pocket",
"max_engagement_deg": 90,
"boundary_tolerance_mm": 0.01,
"clockwise": true,
"min_orbit_radius_mm": 0.25
"max_engagement_deg": 90
}
]
}
2 changes: 0 additions & 2 deletions fixtures/operations/adaptive-pocket.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@
{
"kind": "adaptive_pocket",
"max_engagement_deg": 90,
"boundary_tolerance_mm": 0.01,
"clockwise": true,
"id": "adaptive",
"tool": "t1",
"region": {
Expand Down
189 changes: 0 additions & 189 deletions fixtures/operations/adaptive-tapered.json

This file was deleted.

7 changes: 1 addition & 6 deletions fixtures/operations/helical-adaptive.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,7 @@
"angle_rad": 0.05235987755982989
},
"kind": "adaptive_pocket",
"max_engagement_deg": 90,
"boundary_tolerance_mm": 0.01,
"clockwise": true,
"orbit_radius_mm": 1,
"min_orbit_radius_mm": 0.25,
"local_orbit_tolerance_mm": 0.05
"max_engagement_deg": 90
}
],
"initial_position_mm": [
Expand Down
6 changes: 1 addition & 5 deletions fixtures/operations/roughing-adaptive.json
Original file line number Diff line number Diff line change
Expand Up @@ -841,11 +841,7 @@
"clearing": {
"kind": "adaptive",
"path_strategy": "engagement_front",
"max_radial_engagement_mm": 0.25,
"orbit_radius_mm": null,
"min_orbit_radius_mm": null,
"local_orbit_tolerance_mm": null,
"boundary_tolerance_mm": 0.01
"max_radial_engagement_mm": 0.25
},
"feed_mm_min": 600,
"plunge_mm_min": 150,
Expand Down
6 changes: 1 addition & 5 deletions fixtures/operations/roughing-open-block.json
Original file line number Diff line number Diff line change
Expand Up @@ -292,11 +292,7 @@
"clearing": {
"kind": "adaptive",
"path_strategy": "engagement_front",
"max_radial_engagement_mm": 3.0,
"orbit_radius_mm": null,
"min_orbit_radius_mm": null,
"local_orbit_tolerance_mm": null,
"boundary_tolerance_mm": 0.01
"max_radial_engagement_mm": 3.0
},
"top_z_mm": 21.0,
"floor_z_mm": 14.0,
Expand Down
Loading
Loading