First implementation for DeviceMotionEvent#32
Open
kersten wants to merge 9 commits into
Open
Conversation
Sorry for reformating code
Owner
|
This is interesting, thanks for this. I'm not going to merge it straight away, because:
I'm going to study what you've done here and try and implement device motion events as an option. Great idea. |
Author
|
This is ok. I know that styling was not necessary, but my IDE did it by itself, sorry for that. I want to fix some more stuff tonight, maybe that could be interesting for you too. Eventually I will integrate the option for enabling disabling too. Greetings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes will make your plugin work with devices that have an gyroscope. If you move the device the parallax effect will be visible.
Known bugs:
I try to finish the bugs in my spare time.
Greetings