Repository navigation
Release 0.20.0: Guide follow-ups and We Recommend - #765
Merged
Merged
Conversation
…o song open (#762) feat(help): Guide shows where to point, explains each song fact, and works with no song open Three gaps in help mode, found by using it: - Turning Guide on gave no hint of where to point. Every control it can explain now glows once, for about a second and a half, and fades, so the screen stays calm afterwards. Large areas such as the waveforms are left out of the glow. - The row of song facts was explained as one block. Each card now explains itself: key and how sure its guess is, BPM, LUFS, duration, dynamic range, tempo stability, and every presence card, naming its instrument. - With no song open, the studio switches Export Mix, the song details button and the analysis cards off for the pointer, so help mode never heard it over them. In help mode they receive the pointer again; Guide still takes every click, so nothing is pressed by accident. Closes #760
…763) feat(recommend): Adrianna Claro on We Recommend, and partner cards with several links Adrianna Claro, a soul and contemporary R&B singer, songwriter and composer, joins Artists & Creators, with her photo and her music on Spotify and Apple Music. Killah Trakz gains Spotify and Apple Music beside Instagram, and NIHIL gains Spotify. A partner card could only hold one link, because the whole card was the link. A card can now carry several: it is then a plain card with one labelled pill per destination, since a link inside a link is invalid HTML and which one a click follows is up to the browser. A card with a single url stays a link as a whole, exactly as before. The README table lists the same links, and is now sorted by category, then name, the order the app already shows them in. Closes #761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the last two changes for 0.20.0 into main. The first part of 0.20.0 (#752, #756, #758) is already on main through #759.
The branch is main plus those two commits, with the same content as next-release (no difference). It replaces #764, which conflicted because next-release still carries the three earlier commits under their pre-rebase ids.
Tested on the same content before merging: full Playwright 464 passed (one unrelated lyrics flake, 24 of 24 on rerun), and an automated run with real separation, 71 of 71 assertions.
Closes #760
Closes #761