Say in the update dialog when a release is a full download - #721
Merged
Merged
Conversation
A release that changes the Python dependencies cannot be applied by the one-click update, which keeps the installed runtime. The dialog then showed only Download with nothing to say why, so a missing "Update now" read as a broken update. When the updater stands down for that reason, and only that one, a line above the buttons says the download is a full package to unzip and run, and that the library stays as it is. In all eleven tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a release changes StemDeck's Python dependencies, the one-click update on Windows and Linux stands down, because it keeps the installed runtime and the new app would need packages that runtime does not have. The dialog then offered only Download, with nothing to say why, so a missing "Update now" looked like a broken update.
Now, when the updater stands down for that reason and only that one, a line above the buttons says so:
Any other reason (an install that is not writable, a release without update assets) shows the dialog as before. The line is in all eleven language tables.
The dialog is drawn by the app already installed, so this first shows on the release after the one that ships it. 0.19.0 carries it, and its own release notes say the same thing at the top for people coming from 0.18.1.
Tests
Closes #720