Rename CAP-0083 + add meta example#1940
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CAP-0083 terminology from “skip ledger” to “empty transaction set” and adds a concrete ledger-close metadata example to clarify the proposed protocol behavior.
Changes:
- Renames CAP-0083 title and references from
STELLAR_VALUE_SKIPtoSTELLAR_VALUE_EMPTY_TX_SET. - Adds a JSON-formatted
LedgerCloseDataexample for an empty transaction set ledger. - Updates downstream impact, security, test case, and implementation wording.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
core/README.md |
Updates the CAP-0083 title in the Core proposals index. |
core/cap-0083.md |
Renames the proposed value type, revises semantics wording, and adds example metadata plus test/implementation references. |
bboston7
commented
May 29, 2026
anupsdf
previously approved these changes
May 29, 2026
This change renames `STELLAR_VALUE_SKIP` to `STELLAR_VALUE_EMPTY_TX_SET` based on feedback on the name "skip" being misleading. It also adds example `LedgerCloseData` meta.
anupsdf
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change renames
STELLAR_VALUE_SKIPtoSTELLAR_VALUE_EMPTY_TX_SETbased on feedback on the name "skip" being misleading. It also adds exampleLedgerCloseDatameta.