Update RWA SEP#1930
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SEP-0057 (T-REX / RWA token standard) to better align the written specification with the referenced implementation, especially around compliance hooks, recovery flows, and identity registry/country data interfaces.
Changes:
- Extend compliance hooks to include
token: Address, and add missing compliance getters (get_modules_for_hook,is_module_registered). - Add
IdentityVerifier::recovery_target(...), add the missingCountryDataManagertrait, and switch country-data trait parameters toVal-based shapes. - Align event specifications with the implementation (rename
Recovery→RecoverySuccess, and removeoperatorfromAddressFrozentopics).
Contributor
Author
|
Prettier check is failing due to sep 23, not this one |
janewang
previously approved these changes
May 12, 2026
Contributor
|
Adding @mootz12 and @marcelosalloum for visibility |
brozorec
reviewed
May 13, 2026
brozorec
approved these changes
May 13, 2026
leighmcculloch
requested changes
May 26, 2026
leighmcculloch
left a comment
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
This change updates a draft SEP without changing its version or changelog. Can those be updated?
leighmcculloch
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After @janewang noticed we are missing
recovery_targetfrom this SEP, I've taken a deeper look to see if there are other discrepancies left. And yes, there were some :)Changes
token: Addressto all five hooks (can_transfer,can_create,transferred,created,destroyed) — required for a single compliance contract to serve multiple RWA tokens with per-token state. Also updated the simplifiedcan_transfersnippet in the Architecture Overview.get_modules_for_hookandis_module_registered.IdentityVerifier: addedrecovery_target(e, old_account) -> Option<Address>.RWAToken::recover_balancecalls into this to confirm an identity recovery has already happened before moving balances.IdentityRegistryStorage: replaced the associated-typetype CountryData: FromVal<Env, Val>withVec<Val>parameters, and added a note explaining the Soroban SDK constraint (#[contractclient]cannot derive on traits with associated types) that drives this choice.Recovery→RecoverySuccessto match the impl.operatortopic fromAddressFrozen(impl emits onlyuser_addressandis_frozen).