Skip to content

Add contract build info SEP proposal.#1711

Merged
fnando merged 11 commits into
masterfrom
contract-build-info
Sep 23, 2025
Merged

Add contract build info SEP proposal.#1711
fnando merged 11 commits into
masterfrom
contract-build-info

Conversation

@fnando

@fnando fnando commented Apr 24, 2025

Copy link
Copy Markdown
Member

No description provided.

@fnando fnando requested a review from leighmcculloch April 24, 2025 17:01
@fnando fnando force-pushed the contract-build-info branch from 31192b8 to 102d41f Compare April 29, 2025 17:21
@fnando

fnando commented Apr 30, 2025

Copy link
Copy Markdown
Member Author

@orbitlens could you please review this as well? thank you!

@fnando fnando force-pushed the contract-build-info branch from f9be3a6 to fcac47a Compare May 6, 2025 17:47
@orbitlens

orbitlens commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This text has nothing to do with my original SEP proposal since you removed a key part of it (the predefined workflow). Despite our multiple lengthy discussions on this particular topic. I don't think that source code authenticity guarantees laid out in the revised version of this SEP are sufficient for us. We cannot risk displaying contract source code links verified using this method on StellarExpert.

Our team spent 2 years trying to make this verification routine work but since SDF is against our approach, I'm retracting my proposal. Please remove my name from the "Authors" section of this draft and feel free to merge it.

@leighmcculloch leighmcculloch removed their request for review June 19, 2025 21:53
@github-actions

github-actions Bot commented Jul 20, 2025

Copy link
Copy Markdown

This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

@github-actions github-actions Bot added the stale label Jul 20, 2025
sagpatil
sagpatil reviewed Aug 20, 2025
View reviewed changes
Comment thread ecosystem/sep-contract-build-info.md Outdated
@janewang janewang removed the stale label Sep 3, 2025
@fnando fnando force-pushed the contract-build-info branch from 6c769f8 to 04849ab Compare September 4, 2025 17:40
@fnando fnando force-pushed the contract-build-info branch from ebe141d to 45dd4ea Compare September 11, 2025 17:59
@fnando fnando requested a review from sagpatil September 11, 2025 18:00
@janewang

janewang commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

@leighmcculloch @sagpatil Can this PR be merged? Is anything blocking it?

@fnando fnando merged commit d72b032 into master Sep 23, 2025
5 checks passed
@fnando fnando deleted the contract-build-info branch September 23, 2025 19:25
@tupui tupui mentioned this pull request Oct 17, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@sagpatil sagpatil Awaiting requested review from sagpatil

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fnando @orbitlens @janewang @leighmcculloch @sagpatil