Add random memo to apply-load transactions#5322
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR extends transaction/test and simulation utilities to support attaching an optional Memo to generated transactions, and uses that capability in apply-load to ensure classic payment transaction hashes are non-deterministic across runs.
Changes:
- Add an optional
std::optional<Memo>parameter to padded transaction builders inTxTests. - Thread optional memo support through
TxGeneratortransaction creation APIs. - Generate and attach a random
MEMO_HASHmemo for apply-load classic payments to avoid deterministic tx hashes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/TxTests.h | Adds optional memo parameter to padded transaction helper declarations. |
| src/test/TxTests.cpp | Applies optional memo to the created V1 transaction envelope and propagates through wrapper. |
| src/simulation/TxGenerator.h | Extends generator APIs to accept an optional memo (defaulting to none). |
| src/simulation/TxGenerator.cpp | Passes memo through to transaction constructors (padded and non-padded). |
| src/simulation/ApplyLoad.cpp | Attaches random memo hashes to generated classic payments to make tx hashes non-deterministic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to preserve the uniqueness of transaction hashes across multiple
apply-loadruns, this PR introduces a random memo to every legacy payment transaction.