Make envelope the default fetch when no subcommand is given#2036
Merged
Conversation
In order to flatten an optional field, I needed to remove the group(skip) on network::Args. But this lead to a conflict because there are multiple groups with an implicit name of 'Args' that were all trying to be flattened. The solution to this was add a specific group id to network::Args.
janewang
pushed a commit
that referenced
this pull request
Jul 9, 2025
* Add tx fetch * Convert transaction response back to xdr * Add int tests for tx fetch * Add fetch envelope and meta * Fix xdr representation for fetch tx * Clean up * Cargo fmt * Clippy * Update FULL_HELP_DOCS.md * Update doc comments * Make envelope the default fetch when no subcommand is given (#2036) * Make envelope the default fetch when no subcommand is given In order to flatten an optional field, I needed to remove the group(skip) on network::Args. But this lead to a conflict because there are multiple groups with an implicit name of 'Args' that were all trying to be flattened. The solution to this was add a specific group id to network::Args. * Make envelope the default fetch when no subcommand is given * Refactor to use args impl * Clean up * Clippy * Update cmd/soroban-cli/src/commands/tx/fetch/mod.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Cargo fmt * Error if a tx is not found on given network * Cleanup checking tx status in fetch args * Clippy * Bump rust version --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to flatten an optional field, I needed to remove the group(skip) on network::Args. But this lead to a conflict because there are multiple groups with an implicit name of 'Args' that were all trying to be flattened. The solution to this was add a specific group id to network::Args.