Remove contract alias length limit#2028
Merged
elizabethengelman merged 2 commits intoMay 16, 2025
Merged
Conversation
Shaptic
reviewed
May 13, 2025
leighmcculloch
approved these changes
May 13, 2025
Member
|
Looks like a test needs updating. |
chadoh
force-pushed
the
fix/rm-alias-length-limit
branch
from
c8cde24 to
fadd2ca
Compare
fnando
changed the title
Does this serve a purpose? Will there be actual problems caused by people (or tooling) creating humongously long aliases? I ran into this limit while incorporating [OpenZeppelin's `fungible-token-interface-example`](https://github.com/OpenZeppelin/stellar-contracts/blob/main/examples/fungible-token-interface/Cargo.toml) into https://github.com/AhaLabs/scaffold-stellar-frontend. The alias is not for human use; it's for tooling. It is generated automatically. But even if people want to create ridiculously long aliases, why should the CLI limit them? Co-authored-by: George <Shaptic@users.noreply.github.com>
chadoh
force-pushed
the
fix/rm-alias-length-limit
branch
from
ac31439 to
0945b62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove 30-char length limit on aliases.
Why
Does this serve a purpose? Will there be actual problems caused by people (or tooling) creating humongously long aliases?
I ran into this limit while incorporating OpenZeppelin's
fungible-token-interface-exampleinto https://github.com/AhaLabs/scaffold-stellar-frontend. The alias is not for human use; it's for tooling. It is generated automatically.But even if people want to create ridiculously long aliases, why should the CLI limit them?
Known limitations
None???