This repository was archived by the owner on Jan 8, 2026. It is now read-only.
build: directly generate js libs to node_modules#130
Open
chadoh wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@tyvdh how's this look to you? |
kalepail
approved these changes
Jul 20, 2023
Contributor
kalepail
left a comment
kalepail
left a comment
There was a problem hiding this comment.
I don't love, but approve, of these changes.
At some point we need a Real NPM Pro™ to assess our jankyness and recommend the best case here. But for now, this is better than what we had and if it works better than what we have I'm all for it.
chadoh
force-pushed
the
build/better-gen
branch
3 times, most recently
from
c9bb315 to
677122f
Compare
Contributor
Author
|
|
chadoh
force-pushed
the
build/better-gen
branch
from
55b558e to
d825f43
Compare
Contributor
Author
|
@tyvdh the build finally passes 😅 |
Roll back stellar#122, but keep `crowdfund-contract` and `abundance-token` in `optionalDependencies`. As I worked with the old version in earnest, iterating on a local copy of the CLI and generating new JS libs over and over, the two-step generate-to-.soroban, then install-to-node_modules wasn't working very well. Probably because the new library wasn't being added until the `postinstall` step, and the dependencies are optional. Generating directly to `node_modules` feels dirty, but it works consistently. At least in this version, you can still see the dependencies listed in the `optionalDependencies` section, so they're not quite as surprising/mysterious.
Contributor
|
Looks like the deps are once again completely absent from |
chadoh
force-pushed
the
build/better-gen
branch
from
d825f43 to
b0bebf6
Compare
Contributor
Author
Contributor
|
I just find it hard to believe there isn't a way to handle local packages. How are actual npm packages handling this with CI/CD flows? |
Contributor
|
Maybe helpful? |
Contributor
Author
|
Good find; trying it out with the latest commit |
chadoh
force-pushed
the
build/better-gen
branch
2 times, most recently
from
9dd26ee to
b9c3415
Compare
chadoh
force-pushed
the
build/better-gen
branch
from
b9c3415 to
ccbae90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Roll back #122, but keep
crowdfund-contractandabundance-tokeninoptionalDependencies.This also adds a
.gitattributesto suppresspackage-lock.jsondiffs.Why
As I worked with the old version in earnest, iterating on a local copy of the CLI and generating new JS libs over and over, the two-step generate-to-.soroban, then install-to-node_modules wasn't working very well. Probably because the new library wasn't being added until the
postinstallstep, and the dependencies are optional.Generating directly to
node_modulesfeels dirty, but it works consistently. At least in this version, compared to the one before #122, you can still see the dependencies listed in theoptionalDependenciessection, so they're not quite as surprising/mysterious.