Repository navigation
Conversation
… Post The community banner's Subscribe and New Post buttons used the site-wide teal accent (#06D6A9), but legacy renders both as foundation `button primary` — blue #1A5099 with uppercase text (foundation-overrides.scss). Switch the fill/border/hollow variants to #1A5099, add uppercase, drop the bold weight, and restore the subscribe button's 7em min-width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the community page, the Subscribe and New Post buttons render in the site-wide teal accent (#06D6A9) with title-case bold labels, while legacy renders them in foundation primary blue with uppercase labels (see screenshots in issue discussion — legacy shows blue SUBSCRIBE / NEW POST).
Root cause
Legacy styles both buttons as foundation
button primary:foundation-settings.scss:12—primary: #1A5099foundation-overrides.scss:48—button, .button { text-transform: uppercase }SubscribeButton.jsx:62-66—button primary+hollowwhen subscribed,minWidth: 7emCommunityBanner.jsx:187— New Post link usesbutton primaryThe Next.js port hard-coded
#06D6A9(legacy-teal, the link/accent color — not the button color) and missed the uppercase transform and min-width.Changes
components/elements/SubscribeButton.tsx— fill/border/hollow variants switched to#1A5099, adduppercase, dropfont-bold(foundation buttons are regular weight), restoremin-w-[7em]components/elements/CommunityBanner.tsx— New Post button switched to#1A5099, adduppercase, dropfont-boldbutton primarymappingSite-wide teal usage elsewhere (Header, Voting, LoginForm, etc.) is untouched — this only aligns the two community-page buttons with legacy.
Verification
pnpm lint— 0 errors (7 pre-existing warnings, unchanged)pnpm test— 92 files / 1171 tests passed