Repository navigation
test: replace require('fs') with ESM import to restore lint budget (CI) - #4068
Merged
Merged
Conversation
PR #4061 introduced a no-require-imports error in __tests__/proxy.test.ts which exceeds the zero-error lint budget and keeps next's CI red. Switch to a static node:fs import; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #4061 introduced a
no-require-importsESLint error in__tests__/proxy.test.ts:383(require('fs')in the ANONYMOUS_PAGE_CACHE_CONTROL freeze test). The lint budget gate (pnpm lint:ci,scripts/lint-budget.mjs) enforces 0 errors, sonextCI has been red since4871d97c— predating the 2026-09-29 audit-fix batch (#4063-#4067), which kept lint exactly at baseline.Fix
Switch
require('fs')to a staticimport { readFileSync } from 'node:fs'. No behavior change.Verification
pnpm lint:ci:lint ok: 0 errors <= budget 0__tests__/proxy.test.ts: 116/116 pass