Skip to content

chore: fix JavaScript lint errors#13175

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
AkankshaRaj07:fix-lint-no-new-array
Jun 28, 2026
Merged

chore: fix JavaScript lint errors#13175
kgryte merged 2 commits into
stdlib-js:developfrom
AkankshaRaj07:fix-lint-no-new-array

Conversation

@AkankshaRaj07

Copy link
Copy Markdown
Contributor

Resolves #13173

Description

What is the purpose of this pull request?

This pull request:

  • Fixes stdlib/no-new-array linting errors in has-arraybuffer-support/test/test.js and deep-get/examples/index.js by replacing new Array() constructors with array literals ([]) and push().

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted an AI Coding Assistant to understand the codebase and the contribution guidelines, but the proposed changes were fully authored manually by myself.


@stdlib-js/reviewers

Signed-off-by: Akanksha Kumari <akanksha9123@gmail.com>
@AkankshaRaj07 AkankshaRaj07 requested a review from a team June 28, 2026 05:46
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Jun 28, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 28, 2026
Comment thread lib/node_modules/@stdlib/assert/has-arraybuffer-support/test/test.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Jun 28, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/has-arraybuffer-support $\\color{green}140/140$
$\\color{green}+100.00\\%$
$\\color{red}13/14$
$\\color{green}+92.86\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}140/140$
$\\color{green}+100.00\\%$
object/deep-get $\\color{green}414/414$
$\\color{green}+100.00\\%$
$\\color{green}44/44$
$\\color{green}+100.00\\%$
$\\color{green}6/6$
$\\color{green}+100.00\\%$
$\\color{green}414/414$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #13173) chore: fix JavaScript lint errors Jun 28, 2026
@kgryte kgryte merged commit 867f144 into stdlib-js:develop Jun 28, 2026
47 checks passed
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants