test: fix precision qualifier in test descriptions#13172
Merged
Conversation
Changes the `tape` description from "double-precision" to "single-precision" to match the float32 namespace (88% conformance across siblings using the qualifier). The assertion already verifies the float32-coerced value via `float64ToFloat32`; only the test description carried over from the float64 sibling.
Changes the `tape` description from "double-precision" to "single-precision" to match the float32 namespace (88% conformance across siblings using the qualifier). The assertion already verifies the float32-rounded literal `9.869604110717773`; only the test description carried over from the float64 sibling.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jun 27, 2026
constants/float32/phi and pi-squared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cross-package drift analysis of
@stdlib/constants/float32identified two test files whose secondtapedescription saysdouble-precision floating-point numberinstead ofsingle-precision. Each is a one-word swap; the underlying assertions already verify the correct float32 value.@stdlib/constants/float32/phitest/test.jsline 37 described the export as adouble-precision floating-point number, while the assertion comparesFLOAT32_PHIagainstfloat64ToFloat32( 1.618033988749895 )— a single-precision value. Wording carried over from the float64 sibling test. 30 of 34 float32 packages that use the qualifier in their secondtapedescription saysingle-precision(88% conformance); the onlydouble-precisioninstances in the namespace werephiandpi-squared.@stdlib/constants/float32/pi-squaredtest/test.jsline 40 described the export as adouble-precision floating-point number, while the assertion comparesFLOAT32_PI_SQUAREDagainst the literal9.869604110717773— the float32 rounding of π² (the float64 sibling carries9.869604401089358). Same shape asphi; same 88% conformance fix.Related Issues
None.
Questions
No.
Other
Cross-run dedup
constants/float32: refactor: useconstants/float32/naninstats/strided/snanmeanpn#11769, feat: addconstants/float32/inv-two-pi#8981 — neither touchesphi/test/test.jsorpi-squared/test/test.js.chore: update examples and add keyword, merged 2026-06-21) — did not touch either file or the precision qualifier.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated cross-package API-drift detection run against the
@stdlib/constants/float32namespace. Drift was identified by extracting structural and semantic features from every package, computing a per-feature majority pattern (≥75% threshold), and filtering candidate corrections through a three-agent validation pass (one opus semantic-review, one opus cross-reference, one sonnet structural-review). A human will audit and promote the PR out of draft.@stdlib-js/reviewers
Generated by Claude Code