Skip to content

docs: add Git notes correcting recent commit messages#13136

Closed
Planeshifter wants to merge 1 commit into
developfrom
philipp/git-notes-20260625
Closed

docs: add Git notes correcting recent commit messages#13136
Planeshifter wants to merge 1 commit into
developfrom
philipp/git-notes-20260625

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

Adds one Git note file for a commit from the last 24 hours that contains a clear style guide violation.

Flagged commits

  • fcca2dc42: missing ! in breaking-change type — commit has a BREAKING CHANGE: footer but subject uses remove: instead of the required remove!:. The stdlib git style guide (docs/style-guides/git/README.md) states: "Breaking changes must include an exclamation point as part of the type."

Notes

  • Only one commit was flagged out of 20 non-merge commits in the last 24 hours.
  • All 17 PR-URL references were verified to exist and match their respective commits.
  • All other commit messages follow the correct type(scope): description format.

Checklist

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove already implies breaking changes, so adding the ! is not necessary.

@kgryte kgryte closed this Jun 25, 2026
@kgryte kgryte deleted the philipp/git-notes-20260625 branch June 25, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants