docs: add Git notes correcting recent commit messages#13136
docs: add Git notes correcting recent commit messages#13136Planeshifter wants to merge 1 commit into
Conversation
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
kgryte
left a comment
There was a problem hiding this comment.
remove already implies breaking changes, so adding the ! is not necessary.
Summary
Adds one Git note file for a commit from the last 24 hours that contains a clear style guide violation.
Flagged commits
fcca2dc42: missing!in breaking-change type — commit has aBREAKING CHANGE:footer but subject usesremove:instead of the requiredremove!:. The stdlib git style guide (docs/style-guides/git/README.md) states: "Breaking changes must include an exclamation point as part of the type."Notes
type(scope): descriptionformat.Checklist