Skip to content

style: follow-up fixes for develop commits (2026-06-24 → 2026-06-25)#13131

Closed
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-commit-review-2026-06-25
Closed

style: follow-up fixes for develop commits (2026-06-24 → 2026-06-25)#13131
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-commit-review-2026-06-25

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves #na.

Description

Follow-up fixes for commits merged to develop between 2026-06-24 23:56 UTC and 2026-06-25 10:24 UTC (SHAs 4a1467352..f0362db28, 20 commits).

This pull request:

  • In blas/ext/base/gwxsy/docs/repl.txt (3eace62, line 78), the .ndarray signature is missing spaces after several commas — x,strideX,offsetX, y,strideY,offsetY, w,strideW,offsetW — inconsistent with every peer package in the directory (gxpy, gxsy, gwaxpb, gxmy). Replace with N, x, strideX, offsetX, y, strideY, offsetY, w, strideW, offsetW.

Related Issues

None.

Questions

No.

Other

Validation

What was checked across the 20 develop commits in the window:

  • stdlib code style compliance for the three new BLAS ext/base packages (gwaxpb, gwxsy, gxmy) against established peer packages (gxpy, gxsy, gwaxpb).
  • stdlib code style compliance for the modified files (blas/base/dtrmv enum refactor, .d.ts simplifications, doc fixes, EditorConfig fixes, stats namespace removal, CI workflow patch, ndarray/base/assert TS additions).
  • Bug scan over the union diff (git diff 4a1467352^..f0362db28) for arithmetic, stride/index, off-by-one, wrong-argument, and copy-paste errors.
  • Logic/security scan for missing returns, resource leaks, command injection in workflow changes, missing argument validation, wrong enum mappings in the dtrmv refactor, and .d.ts-vs-runtime mismatches.

Deliberately excluded (low signal):

  • Stale code comments and any subjective preferences.
  • Anything requiring reads outside the window's diff to validate (e.g. cross-file invariants, downstream consumer behavior).
  • Author-intentional choices: fcca2dc42 namespace removals from stats/base, f30fe0156 .d.ts generic simplification, e2e391ed1 operator-assignment swap in gxpy, 22afd69bd resolved enum values passed through dtrmv, 3db715718/1977f9294 documented submode default correction, and the git fetch ... || true scaffolding in 7b03f883e.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was assembled by an automated commit-review routine: four parallel review agents (two style-compliance, two bug/security) audited the 20 commits merged to develop in the last 24 hours, and findings were filtered down to a single high-signal style violation. The fix itself is a one-line whitespace change; no logic was changed.



Generated by Claude Code

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 25, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gwxsy $\\color{green}331/331$
$\\color{green}+100.00\\%$
$\\color{green}26/26$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}331/331$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Copy link
Copy Markdown
Member Author

Closing as a false positive.

The proposed fix (adding the missing spaces in the .ndarray signature) violates the @stdlib/_tools/repl-txt/rules/line-length rule — the corrected line is 85 chars, over the 80-char limit. The original compressed spacing (x,strideX,offsetX) is a deliberate compromise to keep the signature within the line-length budget; the visual inconsistency with peer packages reflects the fact that gwxsy has 10 positional params on the .ndarray form and the peers have 7. No high-signal issue actually survives after factoring this in.

Local report at ~/drift-reports/commit-review-2026-06-25.md updated to reflect the false positive.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants