Skip to content

feat!: migrate stats/strided/dmediansorted to stats/strided/dmedian-sorted#13123

Closed
Neerajpathak07 wants to merge 6 commits into
stdlib-js:developfrom
Neerajpathak07:feat/migrate-dmedian-sorted
Closed

feat!: migrate stats/strided/dmediansorted to stats/strided/dmedian-sorted#13123
Neerajpathak07 wants to merge 6 commits into
stdlib-js:developfrom
Neerajpathak07:feat/migrate-dmedian-sorted

Conversation

@Neerajpathak07

@Neerajpathak07 Neerajpathak07 commented Jun 25, 2026

Copy link
Copy Markdown
Member

Progresses #12697

Description

What is the purpose of this pull request?

This pull request:

  • Migrates stats/strided/dmediansorted to stats/strided/dmedian-sorted

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

Ref: stdlib-js#12697

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
This commit renames the `dmediansorted` symbol to `dmedianSorted` due to a package migration.

BREAKING CHANGE: rename `dmediansorted` to `dmedianSorted`

To migrate, users should update to the new symbol name.

Ref: stdlib-js#12697

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
Ref: stdlib-js#12697

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
This commit removes `@stdlib/stats/strided/dmediansorted` in favor of
`@stdlib/stats/strided/dmedian-sorted`.

BREAKING CHANGE: remove `stats/strided/dmediansorted`

To migrate, users should update their require/import paths to use
`@stdlib/stats/strided/dmedian-sorted` which provides the same API and implementation.

Ref: stdlib-js#12697

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Neerajpathak07 Neerajpathak07 changed the title Feat/migrate dmedian sorted feat!: migrate stats/strided/dmediansorted to stats/strided/dmedian-sorted Jun 25, 2026
@stdlib-bot

stdlib-bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/alias2related $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/alias2standalone $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/aliases $\\color{green}144/144$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}144/144$
$\\color{green}+100.00\\%$
namespace $\\color{red}40129/40232$
$\\color{green}+99.74\\%$
$\\color{green}113/113$
$\\color{green}+100.00\\%$
$\\color{red}2/11$
$\\color{green}+18.18\\%$
$\\color{red}40129/40232$
$\\color{green}+99.74\\%$
namespace/pkg2alias $\\color{green}100/100$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}100/100$
$\\color{green}+100.00\\%$
namespace/pkg2related $\\color{green}100/100$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}100/100$
$\\color{green}+100.00\\%$
namespace/pkg2standalone $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/standalone2pkg $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
stats/base/ndarray/dmediansorted $\\color{green}103/103$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}103/103$
$\\color{green}+100.00\\%$
stats/strided $\\color{red}68530/79426$
$\\color{green}+86.28\\%$
$\\color{red}1318/1483$
$\\color{green}+88.87\\%$
$\\color{red}0/713$
$\\color{green}+0.00\\%$
$\\color{red}68530/79426$
$\\color{green}+86.28\\%$
stats/strided/dmedian-sorted $\\color{green}258/258$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}258/258$
$\\color{green}+100.00\\%$
stats/strided $\\color{red}68530/79426$
$\\color{green}+86.28\\%$
$\\color{red}1318/1483$
$\\color{green}+88.87\\%$
$\\color{red}0/713$
$\\color{green}+0.00\\%$
$\\color{red}68530/79426$
$\\color{green}+86.28\\%$
stats/strided/mediansorted $\\color{red}284/286$
$\\color{green}+99.30\\%$
$\\color{red}15/16$
$\\color{green}+93.75\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{red}284/286$
$\\color{green}+99.30\\%$
stats/strided/smediansorted $\\color{green}310/310$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}310/310$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review June 25, 2026 07:38
@Neerajpathak07 Neerajpathak07 requested a review from a team June 25, 2026 07:38
@Neerajpathak07 Neerajpathak07 added the release: Major Breaking change requiring a new major release. label Jun 25, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 25, 2026
@kgryte

kgryte commented Jun 25, 2026

Copy link
Copy Markdown
Member

@Neerajpathak07 You'll need to open a another PR. Not sure why you merged in develop to this PR. As stated in the migration guide, in order to land these PRs, they need to have only the desired commits.

@kgryte kgryte closed this Jun 25, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 25, 2026
@Neerajpathak07

Copy link
Copy Markdown
Member Author

Ahh yeah was trying to revise to head so that the changes in the removed important and namspaces could be incorporated in this PR. But nw I'll add a new pr rebasing to head itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants