Skip to content

chore: fix JavaScript lint errors in chi2gof benchmark (issue #13114)#13116

Open
NotFoundOvO wants to merge 1 commit into
stdlib-js:developfrom
NotFoundOvO:fix/js-lint-errors
Open

chore: fix JavaScript lint errors in chi2gof benchmark (issue #13114)#13116
NotFoundOvO wants to merge 1 commit into
stdlib-js:developfrom
NotFoundOvO:fix/js-lint-errors

Conversation

@NotFoundOvO

@NotFoundOvO NotFoundOvO commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

replaced all new Array() constructor calls in the chi2gof benchmark with array literals + push, as the stdlib/no-new-array rule requires.

note: this only fixes the chi2gof benchmark portion of the lint errors. the read-file-list doctest issue appears to be a runtime behavior change that needs deeper investigation.

resolves #13114 (partially)

@NotFoundOvO NotFoundOvO requested a review from a team June 25, 2026 02:16
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jun 25, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. and removed First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants