-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: fix and unify complex parsing logic #13069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f446620
fix: fix `complex/base/parse` for correct parsing behavior
impawstarlight 7931870
fix: update `complex/float64/parse` to use `complex/base/parse`
impawstarlight dc2c10a
refactor: extract regexp out into separate file
impawstarlight 95f9e1d
Merge branch 'develop' into fix/complex-parse
impawstarlight c6c5bc6
chore: update copyright years
stdlib-bot 61880e5
Apply suggestions from code review
kgryte e230063
Apply suggestions from code review
kgryte 6f7e443
Apply suggestions from code review
kgryte 84afd68
Apply suggestions from code review
kgryte a7d8dd1
Apply suggestions from code review
kgryte 91b108c
Apply suggestions from code review
kgryte 9410e4b
Apply suggestions from code review
kgryte f2c988c
Apply suggestions from code review
kgryte badc7ec
Apply suggestions from code review
kgryte 63bfad2
Apply suggestions from code review
kgryte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MAIN // | ||
|
|
||
| /** | ||
| * Returns a regular expression that matches and captures a complex number, supporting standard notation, scientific notation, Infinity, and NaN (e.g., "3+4i", "-1.5e10", "NaN-i"). | ||
| * | ||
| * Regular expression: `/^(?:\s*([+-]?)\s*((?:(?:\d+\.?\d*|\.\d+)(?:[eE][+-]?\d+)?)|Infinity|NaN)\s*(?=$|[+-]))?(?:\s*([+-]?)\s*((?:(?:\d+\.?\d*|\.\d+)(?:[eE][+-]?\d+)?)|Infinity|NaN)?\s*(i)\s*)?$/` | ||
| * | ||
| * - `^` | ||
| * - start of input | ||
| * | ||
| * - `(?:\s*([+-]?)\s*` | ||
| * - open an optional non-capturing group for the real part and capture an optional `+` or `-` literal for its sign, ignoring surrounding whitespace | ||
| * | ||
| * - `((?:(?:\d+\.?\d*|\.\d+)(?:[eE][+-]?\d+)?)|Infinity|NaN)` | ||
| * - capture the real magnitude, matching standard decimals, scientific notation, `Infinity`, or `NaN` | ||
| * | ||
| * - `\s*(?=$|[+-]))?` | ||
| * - match optional trailing whitespace, assert via positive lookahead that the real part is followed by either the end of input or the sign for the imaginary part, and close the real part group | ||
| * | ||
| * - `(?:\s*([+-]?)\s*` | ||
| * - open an optional non-capturing group for the imaginary part and capture an optional `+` or `-` literal for its sign, ignoring surrounding whitespace | ||
| * | ||
| * - `((?:(?:\d+\.?\d*|\.\d+)(?:[eE][+-]?\d+)?)|Infinity|NaN)?` | ||
| * - capture the optional imaginary magnitude, matching standard decimals, scientific notation, `Infinity`, or `NaN` | ||
| * | ||
| * - `\s*(i)\s*)?` | ||
| * - capture the literal character `i` for the imaginary unit, ignoring surrounding whitespace, and close the imaginary part group | ||
| * | ||
| * - `$` | ||
| * - end of input | ||
| * | ||
| * ## Notes | ||
| * | ||
| * - The regular expression has the following capture groups: | ||
| * | ||
| * 1. Sign of real part | ||
|
kgryte marked this conversation as resolved.
|
||
| * 2. Value of real part | ||
| * 3. Sign of imaginary part | ||
| * 4. Value of imaginary part | ||
| * 5. Imaginary suffix 'i' | ||
| * | ||
| * @private | ||
| * @returns {RegExp} regular expression | ||
| */ | ||
| function regexp() { | ||
| return /^(?:\s*([+-]?)\s*((?:(?:\d+\.?\d*|\.\d+)(?:[eE][+-]?\d+)?)|Infinity|NaN)\s*(?=$|[+-]))?(?:\s*([+-]?)\s*((?:(?:\d+\.?\d*|\.\d+)(?:[eE][+-]?\d+)?)|Infinity|NaN)?\s*(i)\s*)?$/; | ||
| } | ||
|
|
||
|
|
||
| // EXPORTS // | ||
|
|
||
| module.exports = regexp; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.