Skip to content

test: fix mismatched test filenames#12991

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-propagation-2026-06-20
Jun 20, 2026
Merged

test: fix mismatched test filenames#12991
kgryte merged 1 commit into
developfrom
philipp/fix-propagation-2026-06-20

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Propagating fixes merged to develop between 2026-06-20 10:57 UTC and 2026-06-20 13:03 UTC to sibling packages.

test: filename mismatches

8ca8ea2b4 renamed stats/base/dists/invgamma/logpdf/test/test.nativs.js to test.native.js. The same defect — a test filename that does not match the lib/ module the test requires, left behind by a typo or a copy-paste from a sibling package — survives in four other packages. Each fix is a pure rename; the offending tests already require the correct lib path internally.

Source commit: 8ca8ea2b4 (test: fix filename).

Target packages:

  • math/base/special/polygamma: test.atinifnityplus.jstest.atinfinityplus.js
  • blas/ext/base/csumkbn: test.zsumkbn.jstest.csumkbn.js and test.zsumkbn.native.jstest.csumkbn.native.js (copy-paste leftover from the sibling zsumkbn package)
  • blas/ext/base/dlast-index-of: test.dindex_of.native.jstest.dlast_index_of.native.js
  • blas/ext/base/slast-index-of: test.sindex_of.native.jstest.slast_index_of.native.js

Related Issues

None.

Questions

No.

Other

Validation

What was checked:

  • Each candidate test file's require( './../lib/<X>.js' ) already resolves to the correctly named lib module that exists on disk, so the rename merely aligns the filename to what the test was always testing.
  • Two independent opus validation passes confirmed the defect at every site, that the test body genuinely exercises the lib function under the corrected name (last-index-of semantic, Complex64 vs Complex128 typing, polygamma atinfinityplus math), and that no package.json script, Makefile, README, fixture loader, or other build artifact references the misspelled filename anywhere in the repo.
  • An opus adaptation pass confirmed every site is a pure git mv — no package.json script edits, no Makefile updates, no cross-package changes needed.
  • A sonnet style-consistency pass confirmed the proposed new filenames match the universal test.<X>.jslib/<X>.js convention used across math/base/special and blas/ext/base (snake-case lib names retain snake-case in the matching test filename).

What was deliberately excluded:

  • math/base/special/powf/test/test.x_is_zero.js testing lib/x_is_zerof.js: the lib file's f suffix is a naming-convention choice rather than a typo, and a maintainer should pick between renaming the test vs. renaming the lib file. Logged as needs-human.
  • Naming-style mismatches under array/to-fancy and _tools/** where the test filename intentionally diverges from the lib (logical grouping with . separators, async vs sync complement tests, etc.).
  • Bot-generated commits in the window (docs: update related packages sections, docs: update namespace table of contents) — these are produced by stdlib-bot from package metadata, so any propagation belongs in the generator.

The full per-site audit log, including the dropped false positives, is recorded locally for future review.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This pull request was generated by a scheduled Claude Code routine that audits the prior 24 hours of merges to develop for fix patterns and propagates the equivalent fix to sibling packages exhibiting the same defect. Two independent opus correctness passes, one opus adaptation pass, and one sonnet style-consistency pass ran in parallel against the candidate sites; only unanimously approved propagations were committed. A human will audit before promoting the PR out of draft.


@stdlib-js/reviewers


Generated by Claude Code

Propagates fix from 8ca8ea2 ("test: fix filename") to sibling packages
where the test filename does not match the lib module the test requires.

In each site, the test's `require( './../lib/<X>.js' )` already points at
the correct lib file; only the local test filename was misspelled or
left over from a copy-pasted sibling. Each fix is a pure rename.

Affected packages:

-   `math/base/special/polygamma`: `test.atinifnityplus.js` ->
    `test.atinfinityplus.js`
-   `blas/ext/base/csumkbn`: `test.zsumkbn.js` -> `test.csumkbn.js`,
    `test.zsumkbn.native.js` -> `test.csumkbn.native.js`
-   `blas/ext/base/dlast-index-of`: `test.dindex_of.native.js` ->
    `test.dlast_index_of.native.js`
-   `blas/ext/base/slast-index-of`: `test.sindex_of.native.js` ->
    `test.slast_index_of.native.js`
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte marked this pull request as ready for review June 20, 2026 21:40
@kgryte kgryte requested a review from a team June 20, 2026 21:40
@kgryte kgryte changed the title test: fix mismatched test filenames across sibling packages test: fix mismatched test filenames Jun 20, 2026
@kgryte kgryte merged commit 5c56631 into develop Jun 20, 2026
18 checks passed
@kgryte kgryte deleted the philipp/fix-propagation-2026-06-20 branch June 20, 2026 21:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 20, 2026
@kgryte kgryte added Tests Pull requests specifically adding tests. and removed Needs Review A pull request which needs code review. labels Jun 20, 2026
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants