feat: add `lapack/base/dlarft` by prajjwalbajpai · Pull Request #12972 · stdlib-js/stdlib

prajjwalbajpai · 2026-06-19T18:20:13Z

Description

What is the purpose of this pull request?

This pull request:

adds lapack/base/dlarft

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted ChatGPT for testcases to get 100% code coverage.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

prajjwalbajpai · 2026-06-19T18:21:51Z

/stdlib update-copyright-years

stdlib-bot · 2026-06-19T18:23:21Z

Coverage Report

Package	Statements	Branches	Functions	Lines
lapack/base/dlarft	$\\color{red}1244/1292$ $\\color{green}+0.35\\%$	$\\color{red}108/114$ $\\color{red}-0.10\\%$	$\\color{red}4/5$ $\\color{red}-6.67\\%$	$\\color{red}1244/1292$ $\\color{green}+0.35\\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2026-06-21T23:22:42Z

+		// Compute T_{2,1} = V_{2,2}
+		for ( j = 0; j < K - l; j++ ) {
+			for ( i = 0; i < l; i++ ) {
+				T[ offsetT + ( strideT1 * ( K - l + i ) ) + ( strideT2 * j ) ] = V[ offsetV + ( strideV1 * ( N - K + j ) ) + ( strideV2 * ( K - l + i ) ) ];


You have a number of repeated arithmetic operations here. I suggest finding a way to simplify and consolidate.

kgryte · 2026-06-21T23:26:01Z

+	// The last case is RQ. Due to how we structured this, if the above 3 are false, then RQ must be true, so we never store this RQ happens when we have backward direction in row storage `RQ = ( !dirf ) & ( !colv )`
+	if ( qr ) {
+		/*
+		Break V apart into 6 components


For these extended comments, I suggest moving to a ## Method section in the JSDoc comment above. We do this in other packages (see, e.g., https://github.com/stdlib-js/stdlib/blob/71f4c292794a8e998319756da25e5c041f2b8e64/lib/node_modules/%40stdlib/stats/strided/dpcorrwd/lib/ndarray.js).

You can then use TeX for equation and matrix markup for each of the qr, lq, etc explainers.

kgryte · 2026-06-21T23:28:16Z

-function wrapper( v ) {
-	return addon( v );
+function isDirection( direct ) {
+	return contains( [ 'forward', 'backward' ] )( direct );


This doesn't make sense. You are creating a new function every time you invoke this.

kgryte · 2026-06-21T23:28:54Z

 * @private
-* @param {boolean} v - input value
-* @returns {boolean} input value
-*
-* @example
-* var v = wrapper( true );
-* // returns true
+* @param {string} direct - direction
+* @returns {boolean} boolean indicating if the string is a valid direction
 */
-function wrapper( v ) {
-	return addon( v );
+function isDirection( direct ) {
+	return contains( [ 'forward', 'backward' ] )( direct );
 }


Suggested change

* @private

* @param {boolean} v - input value

* @returns {boolean} input value

*

* @example

* var v = wrapper( true );

* // returns true

* @param {string} direct - direction

* @returns {boolean} boolean indicating if the string is a valid direction

*/

function wrapper( v ) {

return addon( v );

function isDirection( direct ) {

return contains( [ 'forward', 'backward' ] )( direct );

}

* @private

* @name isDirection

* @type {Function}

* @param {string} direct - direction

* @returns {boolean} boolean indicating if the string is a valid direction

*/

var isDirection= contains( [ 'forward', 'backward' ] );

kgryte · 2026-06-21T23:29:05Z

-
-var main = require( './main.js' );
+function isStorage( store ) {
+	return contains( [ 'columnwise', 'rowwise' ] )( store );


Same comment.

kgryte · 2026-06-21T23:30:34Z

+  "LDV": 3,
+  "V_mat": [
+    [
+      1,


Don't split matrix rows over multiple lines like this. The entire point of the *_mat entries is to provide a visual means of seeing the "shape"/contents of an equivalent matrix in linear memory. By splitting over multiple lines, you are making the reader do a lot more work.

kgryte · 2026-06-21T23:31:01Z

+    [
+      1,
+      0.2,
+      0.3,
+      -0.4,
+      0.5
+    ],


Suggested change

[

1,

0.2,

0.3,

-0.4,

0.5

],

[ 1, 0.2, 0.3, -0.4, 0.5 ],

kgryte · 2026-06-21T23:32:26Z

+  "strideTAU": 2,
+  "offsetTAU": 0,
+  "T": [
+    0,


Same thing here. Arrange the elements in matrix format (rows/columns). e.g.

[ 0, 9999, 0, 9999, 0, 9999, 0, 9999, ... ]

See how much easier it is to visually inspect what the matrix is?

kgryte · 2026-06-21T23:32:51Z

+  "offsetTAU": 0,
+  "T": [
+    0,
+    9999,


These comments apply to all of your fixtures.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

prajjwalbajpai · 2026-06-25T18:27:49Z

Made the changes as per the review.

stdlib-bot added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label Jun 19, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 19, 2026

prajjwalbajpai added GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels Jun 19, 2026

chore: update copyright years

2adb86a

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 19, 2026

prajjwalbajpai added 2 commits June 20, 2026 00:02

kgryte reviewed Jun 21, 2026

View reviewed changes

prajjwalbajpai mentioned this pull request Jun 22, 2026

Weekly Standup (2026-06-22) stdlib-js/meetings#135

Open

prajjwalbajpai marked this pull request as ready for review June 25, 2026 18:23

prajjwalbajpai requested a review from a team June 25, 2026 18:23

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 25, 2026

+                  [
+,
+.2,
+.3,
+                    -0.4,
+.5
+                  ],

-    [
-,
-.2,
-.3,
-      -0.4,
-.5
-    ],
+    [ 1, 0.2, 0.3, -0.4, 0.5 ],

Uh oh!

Uh oh!

Conversation

prajjwalbajpai commented Jun 19, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

prajjwalbajpai commented Jun 19, 2026

Uh oh!

stdlib-bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prajjwalbajpai commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Jun 19, 2026 •

edited

Loading