proxy: fix closure cycles in evm#4322
Open
chirag-parmar wants to merge 1 commit into
Open
Conversation
jangko
reviewed
Jun 12, 2026
| continuation*: proc(): EvmResultVoid {.gcsafe, raises: [].} | ||
| parent* {.cursor.}: Computation # non-owning back pointer | ||
| child*: Computation # owning front pointer | ||
| continuation*: proc(c: Computation): EvmResultVoid {.gcsafe, raises: [].} |
Contributor
There was a problem hiding this comment.
might as well add nimcall pragma to the pragma list to ensure there is no hidden closure.
see #2282
Contributor
Author
There was a problem hiding this comment.
two other parameters are captured memPos and memLen in execSubCall. Can try to refactor and try to fit them in without requiring closures, but its better if we pair this refactor with the overall refactor of evm.
tersec
reviewed
Jun 12, 2026
| extend "gcc.cpp.options.linker", " -flto=auto -Wno-stringop-overflow -Wno-stringop-overread -finline-limit=100000" | ||
|
|
||
| if defined(macosx): | ||
| if defined(macosx) and not defined(emscripten): |
Contributor
There was a problem hiding this comment.
Do non-macos LTO settings work with enscripten? It's a little surprising to juxtapose these two conditions, since emscripten works across other platforms too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.