Skip to content

fix _has_role support check#166

Merged
remollemo merged 1 commit into
mainfrom
remo/fix-discovery-bug
May 20, 2026
Merged

fix _has_role support check#166
remollemo merged 1 commit into
mainfrom
remo/fix-discovery-bug

Conversation

@remollemo

@remollemo remollemo commented May 6, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@remollemo remollemo self-assigned this May 6, 2026
@cursor

cursor Bot commented May 6, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk: a small change to error-string matching that only affects when the script falls back from has_role to legacy role-check entrypoints; main risk is misclassifying unrelated errors as “missing entrypoint.”

Overview
Improves role_discovery.py’s detection of “missing entrypoint” failures by loosening _is_missing_entrypoint_error to match any error message containing both entry and point.

This makes the has_role support probe and runtime checks more likely to correctly fall back to legacy is_<role> entrypoints when RPC/provider error wording differs.

Reviewed by Cursor Bugbot for commit 4468245. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@49c4612). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage        ?   94.69%           
=======================================
  Files           ?       57           
  Lines           ?     3993           
  Branches        ?        0           
=======================================
  Hits            ?     3781           
  Misses          ?      212           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f2d8aeb. Configure here.

Comment thread python/utils/role_discovery.py Outdated
Comment thread python/utils/role_discovery.py

@noa-starkware noa-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noa-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on remollemo).

@remollemo remollemo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remollemo reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on remollemo).

@remollemo remollemo force-pushed the remo/fix-discovery-bug branch from f2d8aeb to 4468245 Compare May 20, 2026 07:53

@remollemo remollemo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remollemo reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on remollemo).

@remollemo remollemo merged commit 3d0c557 into main May 20, 2026
4 checks passed
@remollemo remollemo deleted the remo/fix-discovery-bug branch May 20, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants