Support for ISRC6 (__validate__ & __execute__ ) etc.#23
Merged
Conversation
2. Refactor test and test utils. 3. Generate test.cairo signature via python script (directly). 4. send_tx.py utility to prepare (EFO) for starkly and send tx (normal tx) via rpc. Signed-off-by: Remo <remo@starkware.co>
remollemo
commented
Mar 24, 2026
remollemo
left a comment
Collaborator
Author
There was a problem hiding this comment.
@remollemo reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ItayRosenberg).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Touches core account entrypoints (
__validate__/__execute__) and EIP-712 hashing/signature verification, so any mismatch can break transaction validity or execution restrictions.Overview
Implements ISRC6 on
StarknetEth712Accountby adding__validate__(EIP-712 secp256k1 signature check over a newTransactionstruct) and__execute__(protocol-only caller + tx version gating, executing calls individually), and registersISRC6_IDduring initialization.Extends
eth_712_utils.cairowith EIP-712 hashing for InvokeV3 transactions (TransactionMetadata/Transaction,get_transaction_hash), tx version validation, resource-bounds serialization, and a flexible signature parser foris_valid_signature(accepts 5 or 6 felts).Refactors tests to use fixed deployment addresses for stable precomputed signatures, adds coverage for ISRC6 signature validation,
__validate__/__execute__flows, upgrade via both EFO and regular tx, and enforces signature length checks. Script-side, introduces shared Python EIP-712 hashing (scripts/eip712.py), an idempotent signature generator that rewritestest_utils.cairobetween markers, and a newsend_tx.pyutility to sign/send InvokeV3 or print EFO calldata; updates script dependencies and adds an example calls JSON.Written by Cursor Bugbot for commit fb4f559. This will update automatically on new commits. Configure here.
This change is