test: remove verbose logs in tests, to have a clean report on the screen#1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
The
defaultNodesandclassHashBlaketest suites produced verbose output during execution (result tables, performance metrics, intermediate hash values), reducing the readability of Jest reports. These logs were useful during initial development but add no value in a stabilised test suite.Remove all
console.tableandprintcalls (the latter being aprocess.stdout.writealias) from both files.RPC version (if applicable)
N/A
Usage related changes
Development related changes
__tests__/defaultNodes.test.ts: remove theconsole.tablecall on RPC results and its associatedeslint-disablecomment.__tests__/utils/classHashBlake.test.ts: remove theprinthelper function and all its call sites (intermediate hashes, performance comparison tables, text banners), as well as the speedup calculations that only existed to feed those logs. Timing variables kept in the performance tests are covered bytoBeGreaterThan(0)assertions to avoid ESLint unused-variable errors.Checklist: