Skip to content

test: remove verbose logs in tests, to have a clean report on the screen#1624

Merged
PhilippeR26 merged 1 commit into
starknet-io:developfrom
PhilippeR26:silentTest
Jun 10, 2026
Merged

test: remove verbose logs in tests, to have a clean report on the screen#1624
PhilippeR26 merged 1 commit into
starknet-io:developfrom
PhilippeR26:silentTest

Conversation

@PhilippeR26

Copy link
Copy Markdown
Collaborator

Motivation and Resolution

The defaultNodes and classHashBlake test suites produced verbose output during execution (result tables, performance metrics, intermediate hash values), reducing the readability of Jest reports. These logs were useful during initial development but add no value in a stabilised test suite.

Remove all console.table and print calls (the latter being a process.stdout.write alias) from both files.

RPC version (if applicable)

N/A

Usage related changes

  • No impact on the public API.

Development related changes

  • __tests__/defaultNodes.test.ts: remove the console.table call on RPC results and its associated eslint-disable comment.
  • __tests__/utils/classHashBlake.test.ts: remove the print helper function and all its call sites (intermediate hashes, performance comparison tables, text banners), as well as the speedup calculations that only existed to feed those logs. Timing variables kept in the performance tests are covered by toBeGreaterThan(0) assertions to avoid ESLint unused-variable errors.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Updated the tests
  • All tests are passing

@PhilippeR26 PhilippeR26 merged commit 26f3208 into starknet-io:develop Jun 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant