feat: new external signer to handle external signer provider such as Dfns#1369
Open
fondation451 wants to merge 1 commit into
Open
feat: new external signer to handle external signer provider such as Dfns#1369fondation451 wants to merge 1 commit into
fondation451 wants to merge 1 commit into
Conversation
Member
|
I don't see a gain in doing a simple wrapper, as any dev can extend Signer on their own for whatever it's needed. |
Member
|
bump |
Collaborator
|
@tabaktoni this is dfns @fondation451 is talking about https://docs.dfns.co/d/api-docs/keys we know that some dapps on Starknet are using it as KMS |
Member
|
This is fine, but we need either tests or at least documentation examples of how the devs would use it. |
Collaborator
|
@fondation451 could you please add tests and doc 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Before, there was only a default signer with direct access to the private key. I have been using wallet provider such as Dfns which provides signing functions as a service. I derived from the implementation of the default signer, a signer that rely on an external service. I think that it may be useful to have it in the library.
Usage related changes
Development related changes
Checklist: