Fixup Type Annotations - #55
Merged
Merged
Conversation
kdheepak
reviewed
Sep 21, 2026
Comment on lines
+731
to
+732
| def _filter_dict(include: str | None = None, exclude: str | None = None) -> dict[str, str | None]: | ||
| filter_dict: dict[str, str| None] = {} |
Contributor
There was a problem hiding this comment.
I think the return type should be dict[str, str], i.e. without the None. None will never be inserted by this function.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines type annotations in
src/datastar_py/attributes.py.Mappingwhere appropriate. [1] [2] [3] [4]BaseAttrsuper class to include type params:Mapping[str, str | Literal[True]]JSObjectDicttype alias for JavaScript object construction and updated the_js_objecthelper function to use it._modsdictionary attribute type to theTimingMod,DelayMod, andViewtransitionModclasses. These classes is always mixed in withBaseAttr[1] [2] [3]_filter_dict.