Implement earnings-height model in pymc#269
Merged
JTorgander merged 7 commits intoFeb 13, 2026
Merged
Conversation
MansMeg
reviewed
Dec 5, 2025
Collaborator
There was a problem hiding this comment.
How has this file named been changed?
Collaborator
|
Thank you for contributing! Sorry for the delay. The model definition looks good to me and the model passes our consistency checks. I have modified the pymc code to take in data on the form which directly matches the posteriorDB JSON-data and removed some unnecessary extra files. |
JTorgander
approved these changes
Jan 16, 2026
Collaborator
|
Dont we also need to add in the info file, @JTorgander ? |
Collaborator
|
LGTM feel free to merge @JTorgander |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the guide posted by @fonnesbeck here, let me know if this is missing anything!