Skip to content

Eight schools noncentered model in PyMC#264

Merged
JTorgander merged 13 commits into
stan-dev:developmentfrom
fonnesbeck:eight_schools_nc_pymc
Feb 13, 2026
Merged

Eight schools noncentered model in PyMC#264
JTorgander merged 13 commits into
stan-dev:developmentfrom
fonnesbeck:eight_schools_nc_pymc

Conversation

@fonnesbeck

Copy link
Copy Markdown

Updated eight schools noncentered model, using the current version of PyMC.

@MansMeg

MansMeg commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

Great!

Two things.

  1. You now committed the json data file. We keep the data as zip, so it must have been an accident?
  2. Also, there should not be any point of having an additional draws object from pyMC? It should be a true reference draw already.

So I suggest you remove these parts.

@fonnesbeck

Copy link
Copy Markdown
Author

Ah, forgot to zip them -- thanks!

@fonnesbeck

Copy link
Copy Markdown
Author

@MansMeg we are having a posteriordb hackathon today, so there should be a few PRs rolling in over the next few hours/days. Happy to lend a hand if you need.

Let me know if anything else needs changing for this example.

@fonnesbeck

Copy link
Copy Markdown
Author

Is there anything else required here?

@MansMeg

MansMeg commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator

Sorry. Courses are starting so its currently a lot pn my table.

@fonnesbeck

Copy link
Copy Markdown
Author

Understood, no problem! We (the PyMC team) are hoping to implement a bunch of these models in the current version of PyMC over the next few weeks or so. Given your constraints, would you recommend having us fork the project and then you can move them over when you have time?

@MansMeg

MansMeg commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator

Hi! Yes. That is probably the best if you want to use the models asap.

@JTorgander

Copy link
Copy Markdown
Collaborator

Thank you for contributing and sorry for the delay! I have made a minor adjustment to the prior to have it match our Stan model. I have also removed the pymc reference draws since our goal is to use the same draws between PPL's as much as we can.

@JTorgander JTorgander changed the base branch from master to development January 23, 2026 08:40
@fonnesbeck

Copy link
Copy Markdown
Author

Terrific. Anything you need me to do prior to merging?

@JTorgander

Copy link
Copy Markdown
Collaborator

LGTM. @MansMeg?

@MansMeg

MansMeg commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

LGTM - feel free to merge Jakob and then we can soon start to do a new release of posteriordb.

@JTorgander JTorgander merged commit 0fe01bf into stan-dev:development Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants