Skip redemption positions where LTV > 1#766
Merged
Merged
Conversation
tsudmi
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skips redemption positions where LTV > 1 (the user's full minted osToken loan exceeds the value of their vault position).
Redemption lowers a position's LTV when LTV < 1, but raises it when LTV > 1. Redeeming an already-underwater position would push its LTV even higher, which is unwanted, so these positions are now skipped before simulation/submission.
LTV = loan / value, where:
converter.to_assets(vault.osTokenPositions(owner))— the user's total on-chain minted osToken shares (not just the IPFS leaf shares for this round)vault.convertToAssets(vault.getShares(owner))— the user's full vault positionChanges
VaultContract: addget_os_token_positionandget_user_assetshelpers (both back IEthVault ABI calls).redemptions/tasks.py: addis_position_ltv_exceeded.redeem_positions: skip positions failing the LTV check, after the unharvested-vault check and before fetching withdrawable assets.