Repository navigation
bug(site): fix past event filtering for same-day events - #179
Open
suejinkim20 wants to merge 1 commit into
Open
suejinkim20 wants to merge 1 commit into
suejinkim20 wants to merge 1 commit into
Conversation
suejinkim20
marked this pull request as draft
October 14, 2026 13:58
suejinkim20
force-pushed
the
bugfix/event-date
branch
from
October 16, 2026 15:44
00c1b70 to
8661ec2
Compare
suejinkim20
force-pushed
the
bugfix/event-date
branch
from
October 16, 2026 16:06
434670e to
bd6e9cd
Compare
suejinkim20
marked this pull request as ready for review
October 16, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Same-day events were being treated as concluded too early because the site compared only the event date, which made events appear past on the day they occurred.
Solution
Updated past-event logic so events stay current through their event day and only move to past status on the following day. Applied the same rule across event detail pages, event listings, the archive, and homepage event selection so behavior stays consistent.
Testing
npm test -- src/util/eventDateTime.test.tsnpm run build -w @bdc/siteI've also deployed a test branch (not this branch) with an augmented date (shifted wednesday's event to Fri, Oct 16--today) to show this is working.
Note: since this overlaps in fields with the content model PR, I'd recommend doing this one first, then i'll rebase the content model PR on top of this one and readjust the camelCasing and anything else that needs cleaning up